Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp2425pxf; Wed, 7 Apr 2021 18:11:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyeUxRYTukk8B8fj3ddtTzXGsFlT4sEt0tZzZmFwGaTP9yeAcqL1pnc10xXnYrGSJOcwKaX X-Received: by 2002:a50:85cd:: with SMTP id q13mr8133666edh.114.1617844286181; Wed, 07 Apr 2021 18:11:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617844286; cv=none; d=google.com; s=arc-20160816; b=x0STk8bZmS0a420I9ZYmvlT5O3xZU+pq9pO3Do4U8THN4S+1R/K9t1obM0Xyrsaqmr o1QWTOFYTG/SpEqQw0+1Rgt7J/ot2uxBo9U5wtNdpiUMWHcnHgXtlTp/+KxDz2sCUxN9 XKINVSozgZMUvQrIzqpyazEapDiVs5PitC9DA5gWt7tkQZuJKim3tW39kH3jURHjMJ9n yQB/zjXbcvgp9Z96Eonb+mKz6Mf1w+Afz9dHcakqyQZR7AeDEcx4kMuXj554Skfb+i1J qW78+gx5lccgus9bc2DKGdiCw+5XykF3BOCoe3wEmSRoKBPiYjpu1sLkLQ4vnMaI205R yAlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=lA8glmgaGsO4MbyBGlJMT4oTR+BuyM1kHzdhwEeHn6A=; b=MPMt9DQEHuirA8BZ0c6ypPv69F/ITvH5FcdZQxoFhMkL2jG3+J73+7Ow2M4l9M/PTy NrddVqc8LGjRPBcUqoGqKBjwmAeRtqRdAaHjMn7Ry0VO2CwXmRlZXrQSGWbhN8VNyOZ9 PJNxVfSaEBVCzwWWbfmMBz6RZ70Y6Hfi55uRBCkjUe4lLxHputojJjIa6awbzqk8n7e3 9Cw/fD2UjoALW5/UJM9+ek/N/6oZ2i9+naI1Yp/cCsDOFU2bPVpJRRU3sVIsSB//Zcue b6HDFfBF5s/YEWa5fzjesmMh3U3wHpFbbWv8jxzEHLTfYbDp045DwbqrXPfctGELMExi gMGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HUvmZ2ab; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j22si13931543ejy.130.2021.04.07.18.11.00; Wed, 07 Apr 2021 18:11:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HUvmZ2ab; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229939AbhDHBJp (ORCPT + 99 others); Wed, 7 Apr 2021 21:09:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:47672 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229937AbhDHBJk (ORCPT ); Wed, 7 Apr 2021 21:09:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 99E6361168; Thu, 8 Apr 2021 01:09:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617844169; bh=lA8glmgaGsO4MbyBGlJMT4oTR+BuyM1kHzdhwEeHn6A=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=HUvmZ2abFQ9nuM94bTp0xg6A3UizOD+3PE2UUImBH6kKMnAV5XcK7f85deCBZ0BV5 hKpi4BSiV1Z2uKxtGxtI/J8mpywmTGIbaAIJ0NGwps2JbkWLdX14sIUoKFu8MhImlu cGh3P9yI2lg2VIfWSWm31ODGA0SGXQkThcCxE3AS/ftEye3Sy6sxpga5xlfJ4joHjU UZnHH7BeFdPJO8/+CFLW131L7dWg6ipnEaXKU6btx5N/ri2mODQKJ3cplSPPQVnLgZ ZsXBFzqyVfhj3NDKFdD4UefY2n1Hsw18Kx/E+nfzHKm0NHp+LFq+4U1nn02yKJtWZS f1iQ8ALDd5lmQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20210406154015.602779-1-quanyang.wang@windriver.com> References: <20210406154015.602779-1-quanyang.wang@windriver.com> Subject: Re: [V2][PATCH] clk: zynqmp: move zynqmp_pll_set_mode out of round_rate callback From: Stephen Boyd Cc: Greg Kroah-Hartman , Jolly Shah , Rajan Vaja , Quanyang Wang , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org To: Laurent Pinchart , Michael Turquette , Michal Simek , quanyang.wang@windriver.com Date: Wed, 07 Apr 2021 18:09:28 -0700 Message-ID: <161784416839.3790633.9475983970404006080@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting quanyang.wang@windriver.com (2021-04-06 08:40:15) > From: Quanyang Wang >=20 > The round_rate callback should only perform rate calculation and not > involve calling zynqmp_pll_set_mode to change the pll mode. So let's > move zynqmp_pll_set_mode out of round_rate and to set_rate callback. >=20 > Fixes: 3fde0e16d016 ("drivers: clk: Add ZynqMP clock driver") > Reported-by: Laurent Pinchart > Signed-off-by: Quanyang Wang > --- Applied to clk-next