Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Wed, 07 Apr 2021 21:50:15 -0400
Message-Id: <CAHYREM5SP01.DM67S1LUC3NY@shaak>
Cc:     <linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <robh+dt@kernel.org>,
        <kbuild-all@lists.01.org>
Subject: Re: [PATCH] clk: fix for_each_child.cocci warnings
From:   "Liam Beguin" <liambeguin@gmail.com>
To:     "Stephen Boyd" <sboyd@kernel.org>,
        "Julia Lawall" <julia.lawall@inria.fr>, <mturquette@baylibre.com>
References: <alpine.DEB.2.22.394.2104072100410.11549@hadrien>
 <161784187378.3790633.2593540922159647609@swboyd.mtv.corp.google.com>
In-Reply-To: <161784187378.3790633.2593540922159647609@swboyd.mtv.corp.google.com>
Precedence: bulk

Hi Stephen,

On Wed Apr 7, 2021 at 8:31 PM EDT, Stephen Boyd wrote:
> Quoting Julia Lawall (2021-04-07 12:02:32)
> > From: kernel test robot <lkp@intel.com>
> >=20
> > For_each_child_of_node should have of_node_put() before goto.
> >=20
> > Generated by: scripts/coccinelle/iterators/for_each_child.cocci
> >=20
> > CC: Liam Beguin <lvb@xiphos.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> > ---
>
> Is this a fix for a patch on the list?
>

This is a fix for a patch[1] I sent yesterday.
I'll apply and resend.

Thanks,
Liam

[1] https://patchwork.kernel.org/project/linux-clk/patch/20210407005330.289=
0430-2-liambeguin@gmail.com/

> >=20
> > url:    https://github.com/0day-ci/linux/commits/Liam-Beguin/add-suppor=
t-for-the-lmk04832/20210407-085408
> > base:   f40ddce88593482919761f74910f42f4b84c004b
> > :::::: branch date: 9 hours ago
> > :::::: commit date: 9 hours ago
> >=20
> >  clk-lmk04832.c |    1 +
> >  1 file changed, 1 insertion(+)
> >=20
> > --- a/drivers/clk/clk-lmk04832.c
> > +++ b/drivers/clk/clk-lmk04832.c
> > @@ -1159,6 +1159,7 @@ static int lmk04832_probe(struct spi_dev
> >                 if (ret) {
> >                         dev_err(lmk->dev, "missing reg property in chil=
d: %s\n",
> >                                 child->full_name);
> > +                       of_node_put(child);
> >                         goto err_disable_oscin;
> >                 }
> >