Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] drm/bridge: lt8912b: DRM_LONTIUM_LT8912B select
 GPIOLIB
From:   "zhangjianhua (E)" <zhangjianhua18@huawei.com>
To:     Robert Foss <robert.foss@linaro.org>
CC:     Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        "Jernej Skrabec" <jernej.skrabec@siol.net>,
        David Airlie <airlied@linux.ie>,
        "Daniel Vetter" <daniel@ffwll.ch>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        <johnny.chenyi@huawei.com>, <heying24@huawei.com>
References: <20210406090733.169989-1-zhangjianhua18@huawei.com>
 <CAG3jFyvC6ozPxQ=TPdPgLAugKky5AhOZGJSiw0Dc3Kn5Pba0cA@mail.gmail.com>
 <d9bd5abf-0293-6155-dee0-20199fed1fc0@huawei.com>
 <CAG3jFyu6YY5pr5bdvqAbzZu0GG0z=PWP+JHL59G26cg0P=563w@mail.gmail.com>
 <a40abdd7-af43-28a3-1b79-0de6ca0c0093@huawei.com>
Message-ID: <53492034-4cec-12ed-ae27-d693686084ee@huawei.com>
Date:   Thu, 8 Apr 2021 15:10:49 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <a40abdd7-af43-28a3-1b79-0de6ca0c0093@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hello Robert

I am sorry that I make a mistake about the compiling error of lt8912b,

the reason is that lt8912b miss the header file <linux/gpio/consumer.h>.

Although there are many files reference gpiod_set_value_cansleep() and

devm_gpiod_get_optional(), they all include <linux/gpio/consumer.h>

and not occur the compiling error like lt8912b. I have send the second

version patch, please read.


Best regards,

Zhang Jianhua

在 2021/4/7 17:50, zhangjianhua (E) 写道:
> Thanks, I will do that.
>
> 在 2021/4/7 16:03, Robert Foss 写道:
>>> Yes, you are right, there are many files reference
>>> gpiod_set_value_cansleep() and
>>>
>>> devm_gpiod_get_optional(). How about add config dependencies for all
>>> releated
>> I think this is the way to go and roughly half of the drm bridge
>> drivers seem to need this change.
>>
>> Do you mind submitting a series of patches adding this fix for all of
>> the relevant bridge drivers?
>>
>>> configs or only add config dependencies for the top level config?
>>>
>> .