Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp213992pxf; Thu, 8 Apr 2021 01:02:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwq4W4O3m3uJy+YD14SOMr1aZh+ttRWvxI1OdCialTEytiRaW+3iY7UJrXtQO//nOBgSpZP X-Received: by 2002:a05:6a00:1585:b029:203:6bc9:3ca6 with SMTP id u5-20020a056a001585b02902036bc93ca6mr6388665pfk.79.1617868962644; Thu, 08 Apr 2021 01:02:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617868962; cv=none; d=google.com; s=arc-20160816; b=v6uS7JrlSyGSGkZHNjXRgMan656uWIoik40uk2CYGc3s8oL2Tl+quFgkn+BifCrwMD L4vYePkzjxs8xMuC1iHcHx4jzOwupJndc77Qc82koffwCsD8XSRAhkOdBLb0Bnj9gzye uYmV4GYlbGLxAT/xs3SymrSI5pQsZHqDWTwPLckCthkRM6+sK+U3asHkobvMa1Knl1SU ykzvkQ6IG1/PU/YDzLBsj5TdPNNyrT4bMWGzcwd26mfav4wNl9CvNObVksqWHA4DibWU m7Ao97GVER3D4ZdyeP8ZOUk1ISa+Q5QKuH/dQUj1yO4dfYXQCNiBfLPYAjACUlncIJiX NIZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=M3jjVdEdZeB6UsQqbfQxeyoYCfpl7iMTq3rNVg9F2Ug=; b=Pllw2X6RIo8IJBmKBUCO8CWPmseSDHfSVViMBGRb/kKhybs8R4XIMDZyP6pJ2Qz6VD XiLWqc6uWqLA9qu9u4G4PrGYkKmer0k6h8wtRaO14kuex/b/ZPY32givHohHMIMDZdmA OzO4Uhb8ywWCkJj4Z34eLbBC2InIH02pDjxD5lREZ9HoutruopWLrvT1SThwZeX87ZyE ccfIM46VvPFxmFs2h54UZE7ENHGC3YESnjMs4BHD1KPGdIu/NuPaCiNRiyP4+3TY4k75 JhghimOczIwMVBMeDyde4IP2NY564FyL17wGihjp4tBQyKGW78fzuuGRqtTu7gToZxnV Tivg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Tb2jWvIq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q4si16509309pgv.30.2021.04.08.01.02.30; Thu, 08 Apr 2021 01:02:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Tb2jWvIq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229566AbhDHIBk (ORCPT + 99 others); Thu, 8 Apr 2021 04:01:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:59724 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbhDHIBi (ORCPT ); Thu, 8 Apr 2021 04:01:38 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5D30C61130; Thu, 8 Apr 2021 08:01:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617868888; bh=eqLdGS2wSVG1c6ZY6RuWyIqkPV3l6BBB7ZLZz/COD7w=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Tb2jWvIqK20mZpYJsyNx5WmeD7J8YojTitKZNvW3PotaRfZj20JEz665J/h2Hud+9 MdEA12IQkVSTWPuNkP2qUWoecPpnozrEaGJgtDERKXCHtRykuDFGDmkePQvUTr7mx6 FzIKzM1VSdJGUkQ5apkKXK9JcqCMK2L2fm3obEAK25AFS537jEzqr3qgY6EXPcS7Qq qvUjAJpfvaUdpzo6HEN5e/cfgdDflCfpFSI5Sx8molu/ctGVVztVZL67QeJI+kHg2K nOwqM4Ym4h5FUxVCqmcTSx7Nrht8r7R35Al6UV1S/9Qs9BGUKBA+X8TOIYqimnKxsW R6zCzwN7NKCvQ== Date: Thu, 8 Apr 2021 10:01:23 +0200 (CEST) From: Jiri Kosina To: Greg KH cc: Thomas Gleixner , Luis Chamberlain , Minchan Kim , keescook@chromium.org, dhowells@redhat.com, hch@infradead.org, mbenes@suse.com, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Kosina Subject: Re: [PATCH 1/2] zram: fix crashes due to use of cpu hotplug multistate In-Reply-To: Message-ID: References: <20210312183238.GW4332@42.do-not-panic.com> <20210319190924.GK4332@42.do-not-panic.com> <20210322204156.GM4332@42.do-not-panic.com> <20210401235925.GR4332@42.do-not-panic.com> <87blap4kum.ffs@nanos.tec.linutronix.de> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 8 Apr 2021, Greg KH wrote: > Removing a module from a system has always been "let's try it and see!" > type of operation for a very long time. Which part of it? If there is a driver/subsystem code that can't handle the reverse operation to modprobe, it clearly can't handle error handling during modprobe (which, one would hope, is supported), and should be fixed. If there is a particular issue in kernel dynamic linker that causes crash on module removal, we'd better off fixing it. Is there one such that makes you claim module removal unsupported? Thanks, -- Jiri Kosina SUSE Labs