Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210408035435.250677-1-zhangjianhua18@huawei.com>
In-Reply-To: <20210408035435.250677-1-zhangjianhua18@huawei.com>
From:   Robert Foss <robert.foss@linaro.org>
Date:   Thu, 8 Apr 2021 10:30:21 +0200
Message-ID: <CAG3jFysgEC9N1CE1UT4fAgp=ad_89cD7r0=7tD8vF9GvyXCS0A@mail.gmail.com>
Subject: Re: [PATCH -next v2] drm/bridge: lt8912b: Add header file <linux/gpio/consumer.h>
To:     Zhang Jianhua <zhangjianhua18@huawei.com>
Cc:     Adrien Grassein <adrien.grassein@gmail.com>,
        Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@siol.net>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        johnny.chenyi@huawei.com, heying24@huawei.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hey Zhang,


On Thu, 8 Apr 2021 at 05:54, Zhang Jianhua <zhangjianhua18@huawei.com> wrot=
e:
>
> If CONFIG_DRM_LONTIUM_LT8912B=3Dm, the following errors will be seen whil=
e
> compiling lontium-lt8912b.c
>
> drivers/gpu/drm/bridge/lontium-lt8912b.c: In function
> =E2=80=98lt8912_hard_power_on=E2=80=99:
> drivers/gpu/drm/bridge/lontium-lt8912b.c:252:2: error: implicit
> declaration of function =E2=80=98gpiod_set_value_cansleep=E2=80=99; did y=
ou mean
> =E2=80=98gpio_set_value_cansleep=E2=80=99? [-Werror=3Dimplicit-function-d=
eclaration]
>   gpiod_set_value_cansleep(lt->gp_reset, 0);
>   ^~~~~~~~~~~~~~~~~~~~~~~~
>   gpio_set_value_cansleep
> drivers/gpu/drm/bridge/lontium-lt8912b.c: In function =E2=80=98lt8912_par=
se_dt=E2=80=99:
> drivers/gpu/drm/bridge/lontium-lt8912b.c:628:13: error: implicit
> declaration of function =E2=80=98devm_gpiod_get_optional=E2=80=99; did yo=
u mean
> =E2=80=98devm_gpio_request_one=E2=80=99? [-Werror=3Dimplicit-function-dec=
laration]
>   gp_reset =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
>              ^~~~~~~~~~~~~~~~~~~~~~~
>              devm_gpio_request_one
> drivers/gpu/drm/bridge/lontium-lt8912b.c:628:51: error: =E2=80=98GPIOD_OU=
T_HIGH=E2=80=99
> undeclared (first use in this function); did you mean =E2=80=98GPIOF_INIT=
_HIGH=E2=80=99?
>   gp_reset =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
>                                                    ^~~~~~~~~~~~~~
>                                                    GPIOF_INIT_HIGH
>
> Signed-off-by: Zhang Jianhua <zhangjianhua18@huawei.com>
> ---
> v2:
> - add header file <linux/gpio/consumer.h> for lontium-lt8912b.c instead
>   of add config dependence for CONFIG_DRM_LONTIUM_LT8912B
> ---
>  drivers/gpu/drm/bridge/lontium-lt8912b.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c b/drivers/gpu/drm/b=
ridge/lontium-lt8912b.c
> index 61491615bad0..79845b3b19e1 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt8912b.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt8912b.c
> @@ -3,6 +3,7 @@
>   * Copyright (c) 2018, The Linux Foundation. All rights reserved.
>   */
>
> +#include <linux/gpio/consumer.h>
>  #include <linux/device.h>
>  #include <linux/delay.h>
>  #include <linux/i2c.h>

Add this #include in alphabetical order. With this change, feel free
to add my r-b.

Reviewed-by: Robert Foss <robert.foss@linaro.org>

> --
> 2.17.1
>