Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp234318pxf; Thu, 8 Apr 2021 01:39:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCy/aGK/HGG6cD2BZwHL/Pl3Kx1v5TYtBcgZ6VhEBRiixHzq95mc77TlSJK3QVd+afyODZ X-Received: by 2002:a17:906:6d8e:: with SMTP id h14mr8818806ejt.410.1617871140130; Thu, 08 Apr 2021 01:39:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617871140; cv=none; d=google.com; s=arc-20160816; b=imzMjGveNzdgsaJfPOykZiIX75N6P4KX0BH5o4OoSAUrVu6vXmh8CNgPeXRW7FIZYM BOKS+j2ohr/I4kCkKG0VfI1TwBBlaXruExcf7DBdiTqy2o7q2nYdlrRAhdv9lUgg8xFN kKeYVun/hn+MaAsMr4mHqxJwlKa+JaUAx45QivQLReU9Us400u61/7no08YPCxdl7pmf bWMrT6s3cQ2WdFg30jv27YqUsi9LTdsKrRa1v4+ekTa5d9esrjy58Uh4S+VWR5cw+hJ5 O3oL2Ge63QkqVVYALY15zkQrE5mP2j5qctHcFyo/MvQ4T/1/eqrJsl8nSngLEJa2L4+U Eg6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gTRJUY1qblXJejgz2sywV+BWhoT7K1wnHBT96srPwq8=; b=Ux97Cuumy0J5nVOQkOOflfA0/KIf1NcahICj7p+f69PKX4eCGGe02zRVpe37gumSuA LOWGdpvEQ9uPraIQBwUa33Dp0DLItwsvpU1v1vEiEPg39e+CIMByhpy7JUy0Ux5+fZ5z 71j39/2qj83uxgQxczMWHh2XJfU+fhGW9s2hnamOLAQcN3Wf+A42lJZyXLwjBOVhP0QH yNmpk0LLpo/SmG0x+oNKJBYiAZF6fISy0zmQneE8geUi9oHPqGGfZVtltOeQb8y+7w74 9qNJ2X968j7YwukPOhVFwE1laLYc48Tw0almKoMWjtzThJ6Rx7B0Tmb/cRg++DphywfP Vb/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=V6GxBF5j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g16si21444747ejm.310.2021.04.08.01.38.31; Thu, 08 Apr 2021 01:39:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=V6GxBF5j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229767AbhDHIhf (ORCPT + 99 others); Thu, 8 Apr 2021 04:37:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:43322 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbhDHIhe (ORCPT ); Thu, 8 Apr 2021 04:37:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C681A61004; Thu, 8 Apr 2021 08:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617871042; bh=gTRJUY1qblXJejgz2sywV+BWhoT7K1wnHBT96srPwq8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V6GxBF5jSNseCmswWdYSFXiLQuH+aG/A37oCuSEAh7CmY2C6N1PC84DplxdY3O1ui NStz0KauMpzYzjj+qboizZE4QjEjFtgeKAg2sQTmsaEDPk4JoebI/ogPE/QYCw5vov OUZS4GRsv3lRdgaukMhB/Mf4Up4YrjfZyukaYt/w= Date: Thu, 8 Apr 2021 10:37:19 +0200 From: Greg KH To: Mitali Borkar Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, mitali_s@me.iitr.ac.in Subject: Re: [PATCH] staging: rtl8712: removed unnecessary blank line Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Apr 08, 2021 at 01:36:07PM +0530, Mitali Borkar wrote: > Okay, should I rename the patch? I can't take it as-is, so you need to change something :) > I removed a line and matched alignment, so should I rename this > appropriately? Only do one logical thing per patch, so if this is 2 logical things, then you need 2 patches, right? thanks, greg k-h