Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1617197790-30627-1-git-send-email-yangyicong@hisilicon.com>
 <1617197790-30627-4-git-send-email-yangyicong@hisilicon.com>
 <f1d50200-93f5-2c35-933a-01a1e7622983@linux.intel.com> <20210407230421.GB860@kunai>
 <5c478c9b-fc2a-2dd7-6191-8f68e265c2f7@hisilicon.com>
In-Reply-To: <5c478c9b-fc2a-2dd7-6191-8f68e265c2f7@hisilicon.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 8 Apr 2021 12:43:36 +0300
Message-ID: <CAHp75Vfpg4zdSM2eXe8yFsMAJUea_NSjvMRgxqYOF2nDvZA1wg@mail.gmail.com>
Subject: Re: [PATCH v6 3/5] i2c: add support for HiSilicon I2C controller
To:     Yicong Yang <yangyicong@hisilicon.com>
Cc:     Wolfram Sang <wsa@kernel.org>,
        Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-i2c <linux-i2c@vger.kernel.org>,
        Sergey Semin <Sergey.Semin@baikalelectronics.ru>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Dmitry Osipenko <digetx@gmail.com>,
        Thierry Reding <treding@nvidia.com>,
        Russell King <rmk+kernel@armlinux.org.uk>,
        Barry Song <song.bao.hua@hisilicon.com>,
        John Garry <john.garry@huawei.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        prime.zeng@huawei.com, Linuxarm <linuxarm@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Apr 8, 2021 at 10:17 AM Yicong Yang <yangyicong@hisilicon.com> wrote:
> On 2021/4/8 7:04, Wolfram Sang wrote:
> >
> >> Reason for temp variable is for me it's confusing to see statement like
> >> "rate_khz = rate_khz / 1000".
> >
> > Yes. And with this clearer calculation, we can maybe skip the HZ_PER_KHZ
> > define completely and just use plain '1000' as a factor/divider because
> > it then becomes obvious. I still find the define more confusing than
> > helpful TBH. But I'll leave the final decision to Yicong Yang.
> >
>
> HZ_PER_KHZ macro are defined separately in other places of the kernel.
> Andy suggested to have this defined and used so that one day we can factor
> this macro out to the public. :)

Right, and I'm still for the idea to have a macro defined.

-- 
With Best Regards,
Andy Shevchenko