Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp273183pxf; Thu, 8 Apr 2021 02:49:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz5reRcnP+3QS1sZGl+gz0jjW6PZ7puzCNOwIW6ahsmXGX2cGoC8g39Db4CXtHna0SfUCsz X-Received: by 2002:a17:907:e9e:: with SMTP id ho30mr9265783ejc.300.1617875344533; Thu, 08 Apr 2021 02:49:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617875344; cv=none; d=google.com; s=arc-20160816; b=UqT635dNoGU4VyEpR39GRjqbt5u4AfzR0U+/M/q//FTHr+J5MvYbn58Lnd1UXpl5T6 beByolAeWfk4tUILs8MR6jhwpOWd/paGTOR/wH6xkZAmRuWjQ2gThwLGD1bW+WVmWsj2 /EtzcwCZctswNALRA9d+hNdtQeUENVum322IN39XTyNFIJX+kS4J8bubJRuA0UFN8wLp DmGmDLyyXHZ6llXnWVTZ306jEgdRMzOUk1NQ67wJC5IRSAZZW4e599EgePvBM+eSg2hJ vT9r7jifycYfzelY4/RYuZYANvIhWQyDJuKQtl2KXafkMqR9VUHsoW475W8ajtEKZ4Ht J8Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=TtdXzXBPLt1NpXRHI1jvK3500jt84FDBR2C81bVmozs=; b=IAWrjvySBsEnFsYwe3AqCG8MrdGTuN8d7OoOBtaE6ElXsmZJo7T6wJuUfLPEisp0sP NG/nPU1PudErjccHLj0aW6L6zD8KdKp2LLSZZpz5ATRs1TJPHLSgmxvjboRrRz8p0urm jmfTOGhzgO5jQEFaS9BxRbDOnUssoZ6J5VNHzJwYjYZJF5BkBpP333LWy4uv3ITDkwAb Ksb9TFW/jBvKVPmsa+TUC+ovAYASOw8XuWr/Hi3AmU/EQbjHQOK3zoieFEfADNEsYU8/ STjURsMpMO0veBhHbsa6TFXDlIPdWPdAVxl5EG4sAsBtd+GpqLW2YaPgxL4JeJE09jDu wnlA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h13si285021ejt.315.2021.04.08.02.48.41; Thu, 08 Apr 2021 02:49:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231344AbhDHJr7 (ORCPT + 99 others); Thu, 8 Apr 2021 05:47:59 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:16406 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231321AbhDHJr6 (ORCPT ); Thu, 8 Apr 2021 05:47:58 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FGGbm6cgkzkjWR; Thu, 8 Apr 2021 17:45:56 +0800 (CST) Received: from huawei.com (10.67.174.117) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.498.0; Thu, 8 Apr 2021 17:47:38 +0800 From: Ruiqi Gong To: , Talel Shenhar , Zhang Rui , Daniel Lezcano CC: Wang Weiyang , , , Subject: [PATCH -next] thermal: thermal_mmio: remove redundant dev_err call in thermal_mmio_probe() Date: Thu, 8 Apr 2021 06:01:44 -0400 Message-ID: <20210408100144.7494-1-gongruiqi1@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.174.117] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Ruiqi Gong --- drivers/thermal/thermal_mmio.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/thermal/thermal_mmio.c b/drivers/thermal/thermal_mmio.c index d0bdf1ea3331..ded1dd0d4ef7 100644 --- a/drivers/thermal/thermal_mmio.c +++ b/drivers/thermal/thermal_mmio.c @@ -54,11 +54,8 @@ static int thermal_mmio_probe(struct platform_device *pdev) resource = platform_get_resource(pdev, IORESOURCE_MEM, 0); sensor->mmio_base = devm_ioremap_resource(&pdev->dev, resource); - if (IS_ERR(sensor->mmio_base)) { - dev_err(&pdev->dev, "failed to ioremap memory (%ld)\n", - PTR_ERR(sensor->mmio_base)); + if (IS_ERR(sensor->mmio_base)) return PTR_ERR(sensor->mmio_base); - } sensor_init_func = device_get_match_data(&pdev->dev); if (sensor_init_func) {