Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210408081850.24278-1-dinghao.liu@zju.edu.cn>
In-Reply-To: <20210408081850.24278-1-dinghao.liu@zju.edu.cn>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 8 Apr 2021 12:50:49 +0300
Message-ID: <CAHp75VftjKTDJj+8m1HajMfnbLCdZ8UCNxU9wj4Pio0+FK=O4g@mail.gmail.com>
Subject: Re: [PATCH] media: atomisp: Fix runtime PM imbalance in atomisp_pci_probe
To:     Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc:     Kangjie Lu <kjlu@umn.edu>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        linux-staging@lists.linux.dev,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Apr 8, 2021 at 11:19 AM Dinghao Liu <dinghao.liu@zju.edu.cn> wrote:
>
> When hmm_pool_register() fails, a pairing PM usage counter
> increment is needed to keep the counter balanced. It's the
> same for the following error paths.

Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
>  drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> index 0295e2e32d79..02f774ed80c8 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> @@ -1815,6 +1815,7 @@ static int atomisp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i
>         hmm_cleanup();
>         hmm_pool_unregister(HMM_POOL_TYPE_RESERVED);
>  hmm_pool_fail:
> +       pm_runtime_get_noresume(&pdev->dev);
>         destroy_workqueue(isp->wdt_work_queue);
>  wdt_work_queue_fail:
>         atomisp_acc_cleanup(isp);
> --
> 2.17.1
>


-- 
With Best Regards,
Andy Shevchenko