Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] thermal: thermal_mmio: remove redundant dev_err
 call in thermal_mmio_probe()
To:     Ruiqi Gong <gongruiqi1@huawei.com>,
        Zhang Rui <rui.zhang@intel.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>
CC:     Wang Weiyang <wangweiyang2@huawei.com>, <linux-pm@vger.kernel.org>,
        <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Ronen Krupnik <ronenk@amazon.com>, <talelshenhar@gmail.com>,
        <talel@amazon.com>
References: <20210408100144.7494-1-gongruiqi1@huawei.com>
From:   "Shenhar, Talel" <talel@amazon.com>
Message-ID: <60b8e4d4-6baf-4106-b9e1-685652fb2163@amazon.com>
Date:   Thu, 8 Apr 2021 13:01:20 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <20210408100144.7494-1-gongruiqi1@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 4/8/2021 1:01 PM, Ruiqi Gong wrote:
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ruiqi Gong <gongruiqi1@huawei.com>
> ---
>   drivers/thermal/thermal_mmio.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/thermal_mmio.c b/drivers/thermal/thermal_mmio.c
> index d0bdf1ea3331..ded1dd0d4ef7 100644
> --- a/drivers/thermal/thermal_mmio.c
> +++ b/drivers/thermal/thermal_mmio.c
> @@ -54,11 +54,8 @@ static int thermal_mmio_probe(struct platform_device *pdev)
>
>          resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>          sensor->mmio_base = devm_ioremap_resource(&pdev->dev, resource);
> -       if (IS_ERR(sensor->mmio_base)) {
> -               dev_err(&pdev->dev, "failed to ioremap memory (%ld)\n",
> -                       PTR_ERR(sensor->mmio_base));
> +       if (IS_ERR(sensor->mmio_base))
>                  return PTR_ERR(sensor->mmio_base);
> -       }
>
>          sensor_init_func = device_get_match_data(&pdev->dev);
>          if (sensor_init_func) {
Acked-by: Talel Shenhar <talel@amazon.com>