Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp349517pxf; Thu, 8 Apr 2021 04:35:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx161XC3qV2tYfnK7wINVBsdNX9i/3d2RMC/49xKuLPi6872b1FJHxFDzypDoky5TObPjLH X-Received: by 2002:a17:907:1049:: with SMTP id oy9mr9701596ejb.431.1617881748200; Thu, 08 Apr 2021 04:35:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617881748; cv=none; d=google.com; s=arc-20160816; b=QfrGM73UdvTr+It2JSrf5cAEFVFatLdQbOpKcfMrxQGHeK64Q8YLfYC+ca8izcXTTI qzOC5TbejeWBVqLkcTmhhHhiRSivQ4SYEgNyE0nrpttFo39SjMJSTEJ4BRQA55Bz2tBF XwclLpmnO4qbpsg70ztpHJOlOjc0APkYWFSIrt8YNtr+yeMWz32lFfnSRXKd1sQxNSt4 NMlVpjleSW0FYp8haHwvN4gVH1tF+dDVzIvny7kqGNzD3QZBbuQGyjBAQJ83Ldxm2cka VErGfy6iRZQv4ucF2RQgpFSlACMIy8CHwznBj8LpM9uzoS+V9mlCz+PKDfkS/yIysYMM XbSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature; bh=tDIOVgigbNQz2wYXvUtfW44dlC0pAdBtG9TE2EYQHS8=; b=jcYiDlbSxDBgq84cjO0LJRvqEt8Y3kKJzPqtEw9dpqB0UvnlOl9qvgMF3peL3F25eb UkKGj2qiG2tmmSrdBumjMR7mAznyCdbnsTiK2V87d8vEyyu3tvVR0tJ5/ODwcTjlr9/2 ll+2bPFNFcyyi1BZdP65Z91cJoNiLjLGhX/INRgnQpSKZBNdD7AD342jxxIx41mU/Kcc HASBYczj9U6H5t2J1GDNeWmiZ8+zzEngu7ksWYXF2oiI75MB48h2QVvHgXdc6U9E3191 eC5MHfbfcYsFXcBmPnOjOyCwD0CczvHv2mw5LTfbQSoGQyo/LLPcYFfdjhRZynDl4PH3 q4uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=Z75+dZcY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r22si13126563edw.235.2021.04.08.04.35.25; Thu, 08 Apr 2021 04:35:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=Z75+dZcY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230503AbhDHLeh (ORCPT + 99 others); Thu, 8 Apr 2021 07:34:37 -0400 Received: from mx2.suse.de ([195.135.220.15]:59226 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229803AbhDHLeh (ORCPT ); Thu, 8 Apr 2021 07:34:37 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617881664; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tDIOVgigbNQz2wYXvUtfW44dlC0pAdBtG9TE2EYQHS8=; b=Z75+dZcYRxtLlGt8Qfw12bo1a8OYGbZrI8c+G1NJMtOS1MAQYGzDbj2f4Z+d1r8ssOrtQb 37oOad0lWvKW7juG7jK7mMyyqNzfZfokKN5KRCZ5y09v1V8Mf5Lgdl+QC13k+tY7pUWzcm emrh/I3NkpxMy6T1k0qGQAhBsrGMFDw= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C4DCCB294; Thu, 8 Apr 2021 11:34:24 +0000 (UTC) Message-ID: <0049152ce9da85c50fda91c1b77ca233ba0fef3d.camel@suse.com> Subject: Re: [PATCH 3/3] USB: cdc-acm: fix TIOCGSERIAL implementation From: Oliver Neukum To: Johan Hovold Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 08 Apr 2021 13:34:12 +0200 In-Reply-To: References: <20210407102845.32720-1-johan@kernel.org> <20210407102845.32720-4-johan@kernel.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, den 08.04.2021, 11:48 +0200 schrieb Johan Hovold: > On Thu, Apr 08, 2021 at 10:36:46AM +0200, Oliver Neukum wrote: > > Am Mittwoch, den 07.04.2021, 12:28 +0200 schrieb Johan Hovold: > > Well, the devices report it. It is part of the standard. > > No, the standard doesn't include anything about a baud-base clock > AFAICT. Unfortunately it does. dwDTERate - chapter 6.3.11 - table 17 If we does this wrongly, we should certainly fix it, but just removing the reporting doesn't look right to me. Regards Oliver