Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp349773pxf; Thu, 8 Apr 2021 04:36:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxO4/QYkLPNUbA4TQ9ZFGt+WdlwhNQFNlOsANjZxlTEnlR/ESMTBcGWEqeEVc+PU+uI9GVU X-Received: by 2002:a17:906:c08f:: with SMTP id f15mr9809398ejz.318.1617881771067; Thu, 08 Apr 2021 04:36:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617881771; cv=none; d=google.com; s=arc-20160816; b=qmPyi8SXmLgA9Ee58EUcDcd9Bt71GML3NcjB11npVn6QO7UlyrA3UpsIbrwwd7S2cH nZHgO58vAuhnVw7fB6+f+/p2PXWdi1FPzXZD2HwVNMenICSDCXui5/awHZrDAsZZh0q+ tnmcaUTXLGraER+2wVwrK8jb2gkxS1caVVCiDww16WKcA47PyK5XBT6+ARzXhobvB3rl fUgDtTHkSoSxZuSOkctVnpLIGMx1MW8SE8M93PJExeRoEKCmVzhqxd/DsMZpuXQ06f5A PpaV0+K0DNznATj5uUFQOTknSZ6/JcK6eTl9fteGyGYEtXna3uSeRbetJIxqq4y3BWmU XXPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=WGp6WkOlJKevC8h7w6KEAyYrofyyC1mqRUalpONmL4k=; b=u6C2f21jJkB1/T8iQQXB7Do9M/EinWh7R9yemVMF1VNZp5pWynMyPkpSZqDOlBB+gp yOs/NEcLeBLAlut3kosEX59FSIAGyqPLVbnpSABxLYSQR8Mkd9Xz9IUOuZrzAKSNXWA2 Pra7uBhIFyPhlyYkAlaIt53dn3NiUKPBvIiRjzWsQEoEDfIPq+cBYaAB6yPDHrl6U1Xy C688EINVaLRNLvUVkmuCUQ+MFvx4fIa3RcL8deRrE5wLzd+rwcHfxF14WpkjFlmu5Y4e 13NKbwurm4dI20imClGhTVR2nxoUa9z95nBnNb7Y1hlLsECbby9YfzVn7u5/J3VpXvQ/ 5Mew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q2si20701512ejj.541.2021.04.08.04.35.48; Thu, 08 Apr 2021 04:36:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231344AbhDHLep (ORCPT + 99 others); Thu, 8 Apr 2021 07:34:45 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:16837 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231259AbhDHLen (ORCPT ); Thu, 8 Apr 2021 07:34:43 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FGJyV1bC9z7tyD; Thu, 8 Apr 2021 19:32:18 +0800 (CST) Received: from huawei.com (10.175.112.208) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Thu, 8 Apr 2021 19:34:19 +0800 From: Wang Wensheng To: , , , , , CC: Subject: [PATCH -next] RDMA/srpt: Fix error return code in srpt_cm_req_recv() Date: Thu, 8 Apr 2021 11:31:32 +0000 Message-ID: <20210408113132.87250-1-wangwensheng4@huawei.com> X-Mailer: git-send-email 2.9.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.112.208] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: db7683d7deb2 ("IB/srpt: Fix login-related race conditions") Reported-by: Hulk Robot Signed-off-by: Wang Wensheng --- drivers/infiniband/ulp/srpt/ib_srpt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c index 98a393d..ea44780 100644 --- a/drivers/infiniband/ulp/srpt/ib_srpt.c +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c @@ -2382,6 +2382,7 @@ static int srpt_cm_req_recv(struct srpt_device *const sdev, pr_info("rejected SRP_LOGIN_REQ because target %s_%d is not enabled\n", dev_name(&sdev->device->dev), port_num); mutex_unlock(&sport->mutex); + ret = -EINVAL; goto reject; } -- 2.9.4