Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp349983pxf; Thu, 8 Apr 2021 04:36:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJweSDREszqb/u2+i6DuYUZ35e25ZgilKiM4hUU12QLjm7QjKNFyeQYrWqR2XlR8mHw2eNBC X-Received: by 2002:a17:906:8410:: with SMTP id n16mr9847094ejx.378.1617881792979; Thu, 08 Apr 2021 04:36:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617881792; cv=none; d=google.com; s=arc-20160816; b=PR9KAYLZ52xj2LRWPCxpQGVYFF8WBI1n5xCLGQnxiwCmv6VTLj3XgAuW9WxasmXCpV dyC/y7S6RpAQ2RbW91f+kibyfNIZbp5iTsaO5ODq/7M2Nihb/HNz/97sOFHauvHkvjZ6 R1ESvN9BvhYeb0psN8Kkq6Nd+Ed0L+oxb/PaDEMrMAlZLLdxTG1uAeQtCV/iQxMfmKiF RNt8OwiFQj3pO709PaiXaH/KlhCEkhLGK4WaVO+ZDqh9dWbFlud/S1agJj4vo3K3RhMy Xw2GTkOGuq44V3Xd7ImX/T0jvwEY9uJ6NIZOMNNLZaV0A7BI+0WH3lm1T9iP2QOMpOwJ 0NcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=qs/loR8QIi3/ns86ZQlg4gr4L9ZNEDlak8o34Q6XxI4=; b=yhe1pDkjevDkj6PGit6go5kwoCbCawsOa6a3s17oDTSvcZZrwhwTfK/EkVjxdajesd PfXMGBEhivPNCB1hqIR7vlwM19JYW118pN6CIE0ba393MzQNMp+g6m2IsyzAlzzZ3vVi LcMsV/vR2uEDOMqFcDK/P0LuUywP8wqIHlSL8Jq82q8LI5bGYgg7ZHcwOPCveGRZMa/1 Jq13Vg/Xn/8gv/AwR6c4EFQXDclcrmGTcy9KV0oO0wftjx16qXzA5fJ8qYXsUvoYIieT lB+tVag399hy24/M9e2iJER/JLdoShqjkbIYk3T5ACxRit8p386Rk4uPWeV1WFJRnIvl vfNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w15si8298448eja.727.2021.04.08.04.36.08; Thu, 08 Apr 2021 04:36:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231341AbhDHLet (ORCPT + 99 others); Thu, 8 Apr 2021 07:34:49 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:15975 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231396AbhDHLer (ORCPT ); Thu, 8 Apr 2021 07:34:47 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FGJyb3LLvzyNMr; Thu, 8 Apr 2021 19:32:23 +0800 (CST) Received: from huawei.com (10.175.112.208) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.498.0; Thu, 8 Apr 2021 19:34:28 +0800 From: Wang Wensheng To: , , , , , , , , CC: Subject: [PATCH -next] IB/hfi1: Fix error return code in parse_platform_config() Date: Thu, 8 Apr 2021 11:31:40 +0000 Message-ID: <20210408113140.103032-1-wangwensheng4@huawei.com> X-Mailer: git-send-email 2.9.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.112.208] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 7724105686e7 ("IB/hfi1: add driver files") Reported-by: Hulk Robot Signed-off-by: Wang Wensheng --- drivers/infiniband/hw/hfi1/firmware.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/hfi1/firmware.c b/drivers/infiniband/hw/hfi1/firmware.c index 0e83d4b..2cf102b 100644 --- a/drivers/infiniband/hw/hfi1/firmware.c +++ b/drivers/infiniband/hw/hfi1/firmware.c @@ -1916,6 +1916,7 @@ int parse_platform_config(struct hfi1_devdata *dd) dd_dev_err(dd, "%s: Failed CRC check at offset %ld\n", __func__, (ptr - (u32 *)dd->platform_config.data)); + ret = -EINVAL; goto bail; } /* Jump the CRC DWORD */ -- 2.9.4