Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 8 Apr 2021 14:22:32 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc:     Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
        linux-pwm@vger.kernel.org, punit1.agrawal@toshiba.co.jp,
        devicetree@vger.kernel.org, yuji2.ishikawa@toshiba.co.jp,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        kernel@pengutronix.de, Lee Jones <lee.jones@linaro.org>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM
 support
Message-ID: <YG71iGoLHDxNgke4@orome.fritz.box>
References: <20210212131910.557581-1-nobuhiro1.iwamatsu@toshiba.co.jp>
 <20210212131910.557581-3-nobuhiro1.iwamatsu@toshiba.co.jp>
 <20210212164144.wcvy7jkxmrysqxux@pengutronix.de>
 <20210407231548.4paov2fb33cpxxui@toshiba.co.jp>
 <20210408075920.rfrcqxec2yvepj3y@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="rsLTBQx3T/K0yoyF"
Content-Disposition: inline
In-Reply-To: <20210408075920.rfrcqxec2yvepj3y@pengutronix.de>
User-Agent: Mutt/2.0.6 (98f8cb83) (2021-03-06)
Precedence: bulk


--rsLTBQx3T/K0yoyF
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 08, 2021 at 09:59:20AM +0200, Uwe Kleine-K=C3=B6nig wrote:
> Hello Nobuhiro,
>=20
> On Thu, Apr 08, 2021 at 08:15:48AM +0900, Nobuhiro Iwamatsu wrote:
> > > > +	/*
> > > > +	 * pwmc is a 2-bit divider for the input clock running at 1 MHz.
> > > > +	 * When the settings of the PWM are modified, the new values are =
shadowed in hardware until
> > > > +	 * the period register (PCSR) is written and the currently runnin=
g period is completed. This
> > > > +	 * way the hardware switches atomically from the old setting to t=
he new.
> > > > +	 * Also, disabling the hardware completes the currently running p=
eriod and keeps the output
> > > > +	 * at low level at all times.
> > >=20
> > > Did you just copy my optimal description or is your hardware really t=
hat
> > > nice?
> >=20
> > Yes, this hardware works as you wrote.
> > And I added about the state if the sinnal when this hardware disabled.
> >=20
> > >=20
> > > Do you know scripts/checkpatch.pl? I bet it will tell you to limit yo=
ur
> > > lines to approx. 80 chars where sensible.
> >=20
> > Yes, I know. I ran scripts/checkpatch.pl before send patch.
> > I understand that the number of characters per line has been changed to
> > 100 characters. Does the pwm driver recommend 80 characters?
>=20
> For free-text comments I'd still recommend 80, yes. For code lines I'd
> be indeed more lax, as a line break in function calls reduces readability.

Let's not start making any special rules. It becomes impossible for
anyone to keep track of those. If checkpatch doesn't complain for
comments that exceed 80 characters, I will not reject based on that.

Thierry

--rsLTBQx3T/K0yoyF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmBu9YUACgkQ3SOs138+
s6F3gw/+IiJCGh0xj4FlXY2ZbCmanxbp4xUiktkuEcB/PuD2pWjgD9JZ9kexACAI
37AQR8DeJk0T6tsWSBixumda/QjaDPDuzEmsAA/Y1aRK3WrLRM2LZZ63tnsnPE4o
/Rt3gqceqZphYndTY8LC/plK0BZNDwkFKkAOYpdK3fgWgdh6nOsdB7IgC4ua/LKY
Hsfrnd3TPvlKj7ty8cA7E8ujaFh8kvySLLC0XMAJ/Yv0SPDYjI5Tr1SBwTfiaiUB
T5vI6TWHqflQ9JsXSfWLWuhKj0g10KDcyK0nwjbgtxIk7CkjCs/RGpOKhmNAiakK
v1dYr6zLnY4GpFAY9IRN8IQ36s0ffu/l47Ouj0xa6qkoDMvURDmcy4UZU3/QnRLa
M9rMcwyMDsaQV5uQxeV5gXrycLWDIvujFNRcOZFQgLXZZdIp1aLuo/mRGD0fRvQE
qHSo9S+njIlEBkXWhSiqxz4X6JhWh0375kmewF2W+leiPBPpQJWo6uGtWwyEmApV
pcxlaAHGSiftyvfZTZpkuVUP0l2MmVX8yKmeOIgqaPHB2sMwpPRXZ+8is1JMXgiE
oMnh7AMqzbALVZmphrV/NRlDZYAaBSdB2M+zrFMwxSfheQzSkB7ljGBaPUgZ6veR
OmSMD+UKFhUKCW51Y0aHWpCUyWTYsR5b3FqMDweBiOEu43JA7Bk=
=iqAX
-----END PGP SIGNATURE-----

--rsLTBQx3T/K0yoyF--