Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 8 Apr 2021 15:09:04 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Jon Hunter <jonathanh@nvidia.com>
Cc:     Dinghao Liu <dinghao.liu@zju.edu.cn>, kjlu@umn.edu,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Rob Herring <robh@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Vidya Sagar <vidyas@nvidia.com>,
        Jingoo Han <jingoohan1@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: tegra: Fix runtime PM imbalance in
 pex_ep_event_pex_rst_deassert
Message-ID: <YG8AcAJKVC1kFe0n@orome.fritz.box>
References: <20210408072700.15791-1-dinghao.liu@zju.edu.cn>
 <11feff02-c466-5296-b4c3-85754c755c9a@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="uh3Y8H3LtYjscocq"
Content-Disposition: inline
In-Reply-To: <11feff02-c466-5296-b4c3-85754c755c9a@nvidia.com>
User-Agent: Mutt/2.0.6 (98f8cb83) (2021-03-06)
Precedence: bulk


--uh3Y8H3LtYjscocq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 08, 2021 at 01:34:37PM +0100, Jon Hunter wrote:
>=20
> On 08/04/2021 08:26, Dinghao Liu wrote:
> > pm_runtime_get_sync() will increase the runtime PM counter
> > even it returns an error. Thus a pairing decrement is needed
> > to prevent refcount leak. Fix this by replacing this API with
> > pm_runtime_resume_and_get(), which will not change the runtime
> > PM counter on error.
> >=20
> > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> > ---
> >  drivers/pci/controller/dwc/pcie-tegra194.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/c=
ontroller/dwc/pcie-tegra194.c
> > index 6fa216e52d14..0e94190ca4e8 100644
> > --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> > @@ -1645,7 +1645,7 @@ static void pex_ep_event_pex_rst_deassert(struct =
tegra_pcie_dw *pcie)
> >  	if (pcie->ep_state =3D=3D EP_STATE_ENABLED)
> >  		return;
> > =20
> > -	ret =3D pm_runtime_get_sync(dev);
> > +	ret =3D pm_runtime_resume_and_get(dev);
> >  	if (ret < 0) {
> >  		dev_err(dev, "Failed to get runtime sync for PCIe dev: %d\n",
> >  			ret);
> >=20
>=20
> There are two places in the driver where pm_runtime_get_sync() is called.

It looks like the second callsite has the proper cleanup code. Although
it might be nice to use pm_runtime_resume_and_get() there as well, and
adjust the cleanup path, to make this consistent.

In any case, this looks good to me:

Acked-by: Thierry Reding <treding@nvidia.com>

--uh3Y8H3LtYjscocq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmBvAHAACgkQ3SOs138+
s6F+TBAAq8m3qLpGGA3hd/etkHJxjbIjZZTLTIlMHSDIGozQ2o9mcmv3gDnMODUx
uS9O24Jydq0u9RYu8mcET24XRHNP1UvypmAWD3+cfwAsIaNqRYafeaxJyQdhgjFC
8SlIFzU08hyFaCJ0YqszLbcfUvvQof8k6PDtB3CK3CnIWJi4hVKhJ19ykd9b9BNI
+JZO7dYp294qDhlRkum8JsXtiZKtf7wXJnTLtVI3g0wl8cWFXQ97LZJp/a4c+eJm
Rev4kKnGSgxfv0AduzqPN+sjO325kVluhyOcRpC5vNEvCOjuq4QwX1n1Qagr/cUt
rDskxTsKqAtxU5QAJnJzBDDCUDiBw4cq6nw7JOzvZXqrtS+33nLVk9seKRxduSNg
D8f3T0zm2qXorzvIVnNaCsU44c/ljhcsrOf+sOTVvGWx69Fsebs9nWypoHYBYHPb
EkWx+/EEqbRoJhc63az1cDN8M5wKqqOVpMFMWVtVocPe7HvyDvwYJBXoz/RVVR40
qsRBxE/FXJB6m/rQO4Mdo1/RWyLIK1A48hrY+c9EGjXuc3Fo/Z4nXNuKLBtmEb5F
bDwU777xh67kidoW2qhRj9btKRB6boWu9xrdr5KzUbrO2ryok5B3G1cxl6r00u5l
mRQcT3is+Ec5nXvUwLPgFS8H0SfjWJ0siOUmFKzoqyRXk61Ee3I=
=2wcw
-----END PGP SIGNATURE-----

--uh3Y8H3LtYjscocq--