Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <20210327121624.194639-1-zhengzengkai@huawei.com>
References: <20210327121624.194639-1-zhengzengkai@huawei.com>
To:     Zheng Zengkai <zhengzengkai@huawei.com>
Cc:     dhowells@redhat.com, linux-afs@lists.infradead.org,
        linux-kernel@vger.kernel.org, huawei.libin@huawei.com
Subject: Re: [PATCH] afs: fix no return statement in function returning non-void
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6574.1617890815.1@warthog.procyon.org.uk>
Date:   Thu, 08 Apr 2021 15:06:55 +0100
Message-ID: <6575.1617890815@warthog.procyon.org.uk>
Precedence: bulk

Zheng Zengkai <zhengzengkai@huawei.com> wrote:

>  static int afs_dir_set_page_dirty(struct page *page)
>  {
>  	BUG(); /* This should never happen. */
> +	return 0;
>  }

That shouldn't be necessary.  BUG() should be marked as 'no return' to the
compiler.  What arch and compiler are you using?

David