Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Michal Kalderon <mkalderon@marvell.com>
To:     Wang Wensheng <wangwensheng4@huawei.com>,
        Ariel Elior <aelior@marvell.com>,
        "dledford@redhat.com" <dledford@redhat.com>,
        "jgg@ziepe.ca" <jgg@ziepe.ca>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "rui.xiang@huawei.com" <rui.xiang@huawei.com>
Subject: RE: [PATCH -next] RDMA/qedr: Fix error return code in
 qedr_iw_connect()
Thread-Topic: [PATCH -next] RDMA/qedr: Fix error return code in
 qedr_iw_connect()
Thread-Index: AQHXLGspSF2afC7wvUK5itgV43n7+Kqqqnxg
Date:   Thu, 8 Apr 2021 14:16:16 +0000
Message-ID: <MN2PR18MB3182F093EC99B0B676CDC677A1749@MN2PR18MB3182.namprd18.prod.outlook.com>
References: <20210408113135.92165-1-wangwensheng4@huawei.com>
In-Reply-To: <20210408113135.92165-1-wangwensheng4@huawei.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 19b42242-401e-480e-f4db-08d8fa98dfde
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2021 14:16:16.9299
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fVScd9zFCm/iYTRXhHe3RVv3s6QLi+6GTsZm3wc0TT9sm7wO1SRaWrKGazEAI0DvcAPGFBJfcDGcOQvdm66ihg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3493
X-Proofpoint-ORIG-GUID: tRHJDb0gvHdJ3sUJSlV-9EjoAPMi8hkc
X-Proofpoint-GUID: tRHJDb0gvHdJ3sUJSlV-9EjoAPMi8hkc
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761
 definitions=2021-04-08_03:2021-04-08,2021-04-08 signatures=0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Wang Wensheng <wangwensheng4@huawei.com>
> Sent: Thursday, April 8, 2021 2:32 PM
>=20
> Fix to return a negative error code from the error handling case instead =
of 0,
> as done elsewhere in this function.
>=20
> Fixes: 82af6d19d8d9 ("RDMA/qedr: Fix synchronization methods and
> memory leaks in qedr")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Wensheng <wangwensheng4@huawei.com>
> ---
>  drivers/infiniband/hw/qedr/qedr_iw_cm.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/infiniband/hw/qedr/qedr_iw_cm.c
> b/drivers/infiniband/hw/qedr/qedr_iw_cm.c
> index c4bc587..1715fbe 100644
> --- a/drivers/infiniband/hw/qedr/qedr_iw_cm.c
> +++ b/drivers/infiniband/hw/qedr/qedr_iw_cm.c
> @@ -636,8 +636,10 @@ int qedr_iw_connect(struct iw_cm_id *cm_id, struct
> iw_cm_conn_param *conn_param)
>  	memcpy(in_params.local_mac_addr, dev->ndev->dev_addr,
> ETH_ALEN);
>=20
>  	if (test_and_set_bit(QEDR_IWARP_CM_WAIT_FOR_CONNECT,
> -			     &qp->iwarp_cm_flags))
> +			     &qp->iwarp_cm_flags)) {
> +		rc =3D -ENODEV;
>  		goto err; /* QP already being destroyed */
> +	}
>=20
>  	rc =3D dev->ops->iwarp_connect(dev->rdma_ctx, &in_params,
> &out_params);
>  	if (rc) {
> --
> 2.9.4

Thanks,=A0

Acked-by: Michal Kalderon=A0<michal.kalderon@marvell.com>