Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp498150pxf; Thu, 8 Apr 2021 07:22:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwuE0BBk9c+uqeVVq+wEZZ7hGg9PLwTwpzwRs6AE+Z3UnyGG1ND0yXBCbmkZVp7udK9WVow X-Received: by 2002:a17:90b:120a:: with SMTP id gl10mr8725609pjb.212.1617891767124; Thu, 08 Apr 2021 07:22:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617891767; cv=none; d=google.com; s=arc-20160816; b=G9HCx6hpr23lhpgbfOisxn7ogL5Mn9PTCBFBIYJbAxZRPHgVkmxk4Abq98+L/97pww ozmUjEARCLsHPMD1QsYguGaKuLKjbHMIFDrMe0OjOJO8bbpJkss2czrZl0vcUAg+SWyf jggidSlUn301JgQm7GBebdYHY/ScNrY7WmXEVDlB/FchXXxkGC+iNGj1dmWokQKnIJ6G Ss979YADhoSfMItXvSE4vU54bV6eNcJxfrwCuL6jvHPSvBgdnOFuu9UfydHpge1QnaSg 0fqzdqjr2ciXkP538hlpa8a4QWELnGT31EdZv+BPR2OnORYgrDbSNzUrm/zZeEDG4mm1 NuZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:ironport-sdr :ironport-sdr; bh=NVfXXquiLSovJHhZIUARXkcG16/HGpA+sX5TP33bxpo=; b=xOfJ+sm9gGKIDhAufZFnLqdZSaiQo+sDbEB8GrY0UelyVaCUIgc3+MBKMT6ZguKzg3 T4FHBiN4HIH9Br6nzM/xSTwC/6+9oJ7weOhBIYOBnVmIMLLjmLBepuIjS8meMt88oCVc h3piUTO+Nzpwc+7w6jwvnkj25I5XDGcvgUSJDLJTjK8Y86khkcn+umU26qdwFhfJRXIE zdC+yBdYsbNyaiLczUjZcWfr4+wZHWg6vX29UcVcLXc3hloYNuyyePt03O+S0Q12JtlE x5tBJKK3GZhWN/2kot7hdPyttTCH/rIgN6XgoiX5qE52280SeSLt1k0QA/2LawiCkojG eoJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u3si12020359pjf.171.2021.04.08.07.22.34; Thu, 08 Apr 2021 07:22:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231829AbhDHOVw (ORCPT + 99 others); Thu, 8 Apr 2021 10:21:52 -0400 Received: from mga11.intel.com ([192.55.52.93]:21652 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231474AbhDHOVv (ORCPT ); Thu, 8 Apr 2021 10:21:51 -0400 IronPort-SDR: F/zCS/PYFiPqBewprAPKHdDlhLr4eFJ3YwOljlzSgkYyxb4wrCvEi+j2sY2du/IQA1gOL3DtIn OglBt3YOuslg== X-IronPort-AV: E=McAfee;i="6000,8403,9948"; a="190348333" X-IronPort-AV: E=Sophos;i="5.82,206,1613462400"; d="scan'208";a="190348333" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2021 07:21:40 -0700 IronPort-SDR: PN568oKrfQ7hkG6wer9c5pBIDEvPW/meQgHrFz9VTph76i/i77DXF7BW9QpnMfrjZQVcvPG3IY gU/PiJHhtqfQ== X-IronPort-AV: E=Sophos;i="5.82,206,1613462400"; d="scan'208";a="422268065" Received: from tassilo.jf.intel.com ([10.54.74.11]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2021 07:21:40 -0700 Date: Thu, 8 Apr 2021 07:21:39 -0700 From: Andi Kleen To: "Bayduraev, Alexey V" Cc: Arnaldo Carvalho de Melo , Jiri Olsa , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Ingo Molnar , linux-kernel , Adrian Hunter , Alexei Budankov , Alexander Antonov Subject: Re: [PATCH v4 05/12] perf record: start threads in the beginning of trace streaming Message-ID: <20210408142139.GE3762101@tassilo.jf.intel.com> References: <6c15adcb-6a9d-320e-70b5-957c4c8b6ff2@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + err = write(thread->pipes.ack[1], &msg, sizeof(msg)); > + if (err == -1) > + pr_err("threads[%d]: failed to notify on start. Error %m", thread->tid); It might be safer to not use %m. I'm not sure if all the non glibc libcs that people use support it.