Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 8 Apr 2021 15:38:13 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     Wei Liu <wei.liu@kernel.org>,
        Siddharth Chandrasekaran <sidcha@amazon.de>, kys@microsoft.com,
        haiyangz@microsoft.com, sthemmin@microsoft.com, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com,
        seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com,
        jmattson@google.com, joro@8bytes.org, graf@amazon.com,
        eyakovl@amazon.de, linux-hyperv@vger.kernel.org,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 0/4] Add support for XMM fast hypercalls
Message-ID: <20210408153813.iu3teoor6c6m6kzb@liuwe-devbox-debian-v2>
References: <20210407212926.3016-1-sidcha@amazon.de>
 <20210408152817.k4d4hjdqu7hsjllo@liuwe-devbox-debian-v2>
 <033e7d77-d640-2c12-4918-da6b5b7f4e21@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <033e7d77-d640-2c12-4918-da6b5b7f4e21@redhat.com>
Precedence: bulk

On Thu, Apr 08, 2021 at 05:30:26PM +0200, Paolo Bonzini wrote:
> On 08/04/21 17:28, Wei Liu wrote:
> > > Although the Hyper-v TLFS mentions that a guest cannot use this feature
> > > unless the hypervisor advertises support for it, some hypercalls which
> > > we plan on upstreaming in future uses them anyway.
> > 
> > No, please don't do this. Check the feature bit(s) before you issue
> > hypercalls which rely on the extended interface.
> 
> Perhaps Siddharth should clarify this, but I read it as Hyper-V being buggy
> and using XMM arguments unconditionally.
> 

There is no code in upstream Linux that uses the XMM fast hypercall
interface at the moment.

If there is such code, it has bugs in it and should be fixed. :-)

Wei.

> Paolo
>