Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp582481pxf; Thu, 8 Apr 2021 08:56:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx5Xfb9YezzVgvh3sOK7FcCCyzLoEL1bwdj59IR67WA6EXetdh5P2sRS/RBazM+X7MUVCLL X-Received: by 2002:a17:907:2151:: with SMTP id rk17mr1016632ejb.203.1617897368802; Thu, 08 Apr 2021 08:56:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617897368; cv=none; d=google.com; s=arc-20160816; b=omMQ1JiKgmI7TfUtx+h5mx47S6yKX53Um4p8dJdKPx/S4hky7gsOIDa/dMEN0V8iea 7kuOG7gkhPo0RjRTlGceVvHJtuvhbGtpsmfanwXjdCbZTB+EtZ0XN1xCidY4LNeiuDrF FhACvKO9Jbmix3SBS8VTnuoBF5gZhkFt0ZpE+VBson9EFvfs9Jt4aJQ02Uc4MczqMtGB YTe1ldxpWt2e1jHEt6mZqIcImYkbYrOTtB74jUsYcr6ycRH8V0sqO5gQ0nYTvR/m7tyO z02sFa3i8yVoF8SoWeRZKzIYYYKTqR1OxXhBZD220T3s8U/M8pu1uY8v711as9d9D6eX KdHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:to:subject:ironport-sdr:ironport-sdr; bh=pxhhA8cR0X6Lmu01vO9t8/6Q/jz3KAqT8s4EimvtHho=; b=OSAyybfxgaDEOmpqoEqsOe8cbbUAIWeVt6aibe/NxEbEFNG1ICw3NTcvg1qcVXjMPv MQjpP0JR6DHxo5zqMmfR9anw1jbVI2qla+DnOD+Rsm/1jYNJwYV2ydQGPuCuylY4fkpE ne7WFQtuxpBWLIA090L/DeWUXa7TEfJJ3m18P6CLeaNo5hD7Etv82rBQ2R7h6gI4MQ1a LjaH+oRv426DIqzN0v3rO3gu4n2dPYqkFiFe+KDd+nOzLyRjn607YMaIFxpDmX2bat0m A75j+CXZcXJQr7TximtuozhqyPEkDigB5wcIGcEWr3przabsOeFXrCz1KjJ9QKR3DnAY HYEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q4si10464768edb.494.2021.04.08.08.55.43; Thu, 08 Apr 2021 08:56:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231908AbhDHPys (ORCPT + 99 others); Thu, 8 Apr 2021 11:54:48 -0400 Received: from mga14.intel.com ([192.55.52.115]:62010 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231975AbhDHPyr (ORCPT ); Thu, 8 Apr 2021 11:54:47 -0400 IronPort-SDR: s4vy2D635nKgpJDZmk+NWVvPFveN9SZtCfQhKCNlONQtPSosYLq3Vc2wZD/jMeD161a20/q6ul oytPxlBok1gA== X-IronPort-AV: E=McAfee;i="6000,8403,9948"; a="193114343" X-IronPort-AV: E=Sophos;i="5.82,206,1613462400"; d="scan'208";a="193114343" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2021 08:54:35 -0700 IronPort-SDR: SZq/qdzaJQ374p+OXdwuO7y9iTqNegvxVWuMk1aJYTC+b3qDWFSI4RpSCNJjL0H2bQOOGbTvSS h4Z8ge+yVNkQ== X-IronPort-AV: E=Sophos;i="5.82,206,1613462400"; d="scan'208";a="519909750" Received: from mongkaiw-mobl.amr.corp.intel.com (HELO [10.209.62.147]) ([10.209.62.147]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2021 08:54:34 -0700 Subject: Re: [PATCH RESEND 0/3] x86/sgx: eextend ioctl To: Jethro Beekman , Raoul Strackx , Jarkko Sakkinen , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org References: <9688abee-6ba7-e1d9-701e-a5cabac36269@fortanix.com> <0498080e-6fdc-ed6d-8efa-d9c3265fe7e5@intel.com> <9d15aae0-078a-ed72-6c14-155cd1bf27c5@fortanix.com> <247ffbee-0ef6-1b6f-75aa-2dc06df42d5d@intel.com> <4a122198-054f-609e-e96c-b69ff941c8a7@intel.com> <9a841584-65e8-31e9-6bd4-0140b33434e8@fortanix.com> <5af533e2-5bfd-8edc-0eaa-6fd3ddebb211@intel.com> <3a8cec45-87e6-9192-e556-2f3c85ec16dd@fortanix.com> <3eaead9e-e197-4bbb-5666-a6fb24b2b349@intel.com> <619aad50-073d-b0a4-6dcd-3e222166c4a3@fortanix.com> <1eec29ab-b979-7919-677b-2cfa147c4c61@intel.com> <2c38deba-47c1-2800-1215-a3a12cc06316@fortanix.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: Date: Thu, 8 Apr 2021 08:54:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <2c38deba-47c1-2800-1215-a3a12cc06316@fortanix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/8/21 8:27 AM, Jethro Beekman wrote: > But the native “executable format” for SGX is very clearly defined in > the Intel SDM as a specific sequence of ECREATE, EADD, EEXTEND and > EINIT calls. It's that sequence that's used for loading the enclave > and it's that sequence that's used for code signing. So when I say > save space I mean save space in the native format. > > Not EEXTENDing unnecessarily also reduces enclave load time if > you're looking for additional arguments. I look forward to all of this being clearly explained in your resubmission. > SGX defines lots of things and you may not see the use case for all > of this immediately. No one has a usecase for creating enclaves with > SECS.SSAFRAMESIZE = 1000 or TCS.NSSA = 3. Why did you not demand > checks for this in the ECREATE/EADD ioctls? There's a difference between adding code to support a feature and adding code to *RESTRICT* use of a feature.