Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 net-next] net: mana: Add a driver for Microsoft Azure
 Network Adapter (MANA)
To:     decui@microsoft.com, davem@davemloft.net, kuba@kernel.org,
        kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com,
        wei.liu@kernel.org, liuwe@microsoft.com, netdev@vger.kernel.org,
        leon@kernel.org, andrew@lunn.ch, bernd@petrovitsch.priv.at
Cc:     linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org
References: <20210408091543.22369-1-decui@microsoft.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <a44419b3-8ae9-ae42-f1fc-24e308499263@infradead.org>
Date:   Thu, 8 Apr 2021 09:22:57 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <20210408091543.22369-1-decui@microsoft.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/8/21 2:15 AM, Dexuan Cui wrote:
> diff --git a/drivers/net/ethernet/microsoft/Kconfig b/drivers/net/ethernet/microsoft/Kconfig
> new file mode 100644
> index 000000000000..12ef6b581566
> --- /dev/null
> +++ b/drivers/net/ethernet/microsoft/Kconfig
> @@ -0,0 +1,30 @@
> +#
> +# Microsoft Azure network device configuration
> +#
> +
> +config NET_VENDOR_MICROSOFT
> +	bool "Microsoft Azure Network Device"

Seems to me that should be generalized, more like:

	bool "Microsoft Network Devices"


> +	default y
> +	help
> +	  If you have a network (Ethernet) device belonging to this class, say Y.
> +
> +	  Note that the answer to this question doesn't directly affect the
> +	  kernel: saying N will just cause the configurator to skip the
> +	  question about Microsoft Azure network device. If you say Y, you

	           about Microsoft networking devices.

> +	  will be asked for your specific device in the following question.
> +
> +if NET_VENDOR_MICROSOFT
> +
> +config MICROSOFT_MANA
> +	tristate "Microsoft Azure Network Adapter (MANA) support"
> +	default m

Please drop the default m. We don't randomly add drivers to be built.

Or leave this as is and change NET_VENDOR_MICROSOFT to be default n.


> +	depends on PCI_MSI && X86_64
> +	select PCI_HYPERV
> +	help
> +	  This driver supports Microsoft Azure Network Adapter (MANA).
> +	  So far, the driver is only validated on X86_64.

validated how?


> +
> +	  To compile this driver as a module, choose M here.
> +	  The module will be called mana.
> +
> +endif #NET_VENDOR_MICROSOFT


thanks.
-- 
~Randy