Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] KVM: vmx: add mismatched size in vmcs_check32
To:     Sean Christopherson <seanjc@google.com>, lihaiwei.kernel@gmail.com
Cc:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com,
        joro@8bytes.org, Haiwei Li <lihaiwei@tencent.com>
References: <20210408075436.13829-1-lihaiwei.kernel@gmail.com>
 <YG8pwERmjxYQoquP@google.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <c24c9d96-37c5-cfb4-8b84-cb3f8daee500@redhat.com>
Date:   Thu, 8 Apr 2021 18:28:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <YG8pwERmjxYQoquP@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 08/04/21 18:05, Sean Christopherson wrote:
>    Add compile-time assertions in vmcs_check32() to disallow accesses to
>    64-bit and 64-bit high fields via vmcs_{read,write}32().  Upper level
>    KVM code should never do partial accesses to VMCS fields.  KVM handles
>    the split accesses automatically in vmcs_{read,write}64() when running
>    as a 32-bit kernel.

KVM also uses raw vmread/vmwrite (__vmcs_readl/__vmcs_writel) when 
copying to and from the shadow VMCS, so that path will not go through 
vmcs_check32 either.

Paolo