Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Min Li <min.li.xe@renesas.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "derek.kiernan@xilinx.com" <derek.kiernan@xilinx.com>,
        "dragan.cvetic@xilinx.com" <dragan.cvetic@xilinx.com>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next v2 2/2] misc: Add Renesas Synchronization
 Management Unit (SMU) support
Thread-Topic: [PATCH net-next v2 2/2] misc: Add Renesas Synchronization
 Management Unit (SMU) support
Thread-Index: AQHXK9TmRDzfnJqVl0Sq9GK4xidseaqpVacAgAAkN3CAALFwAIAAtcQg
Date:   Thu, 8 Apr 2021 17:36:13 +0000
Message-ID: <OSBPR01MB4773F65136FAE06F275D808CBA749@OSBPR01MB4773.jpnprd01.prod.outlook.com>
References: <1617816815-3785-1-git-send-email-min.li.xe@renesas.com>
 <1617816815-3785-2-git-send-email-min.li.xe@renesas.com>
 <YG3xKlSrOZvrIr3z@kroah.com>
 <OSBPR01MB477360E86A8913D07759C1C8BA759@OSBPR01MB4773.jpnprd01.prod.outlook.com>
 <YG6kZDlCXs4MGHNw@kroah.com>
In-Reply-To: <YG6kZDlCXs4MGHNw@kroah.com>
Accept-Language: en-CA, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e6b9e39-e59a-40c7-5dbc-08d8fab4ce9e
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2021 17:36:13.8698
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cieWQpQx1Vj2RrartagwFfQOX1d2WXCwELIBEkUQnPm2OOMrJrsRD7x0g1iPAfJie5UxGDRdqjZkVhC23V5GdQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSZPR01MB6216
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> Why?
>=20

Because I need to manipulate name by adding the index to it during run time=
 and use it as miscdev's name=20

	snprintf(rsmu->name, sizeof(rsmu->name), "rsmu%d", rsmu->index);
	rsmu->miscdev.name =3D rsmu->name;
>=20
> Then why are you saving it off?
>=20

For things like dev_err(rsmu->dev, "Undefined RSMU IOCTL");

>=20
> Ok, that should be documented a bit, it wasn't obvious :)
>=20

Will do for the next patch

>=20
> So you can just look it up from the name?
>=20

name is based on this index in the first place