Date: Thu, 12 Oct 2006 12:16:37 -0500 (CDT)
From: Brent Casavant <bcasavan@sgi.com>
Reply-To: Brent Casavant <bcasavan@sgi.com>
To: Andrew Morton <akpm@osdl.org>
cc: linux-kernel@vger.kernel.org, Jeremy Higdon <jeremy@sgi.com>,
       Pat Gefre <pfg@sgi.com>
Subject: Re: [PATCH 2/2] ioc4: Enable build on non-SN2
In-Reply-To: <20061011172332.8f7b354f.akpm@osdl.org>
Message-ID: <20061012121528.E85966@pkunk.americas.sgi.com>
References: <20061010120928.V71367@pkunk.americas.sgi.com>
 <20061011172332.8f7b354f.akpm@osdl.org>
Organization: Silicon Graphics, Inc.
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1561
Lines: 42

My sincere apologies for this.

Would you prefer I send a corrected patch (the oversight was actually
in the previous patch in the series), or simply a new patch that
builds atop the other two and fixes the problem?

Thanks,
Brent

On Wed, 11 Oct 2006, Andrew Morton wrote:

> On Tue, 10 Oct 2006 12:11:16 -0500 (CDT)
> Brent Casavant <bcasavan@sgi.com> wrote:
> 
> > The SGI PCI-RT card, based on the SGI IOC4 chip, will be made available
> > on Altix XE (x86_64) platforms in the near future.  As such it is now a
> > misnomer for the IOC4 base device driver to live under drivers/sn, and
> > would complicate builds for non-SN2.
> > 
> > This patch moves the IOC4 base driver code from drivers/sn to drivers/misc,
> > and updates the associated Makefiles and Kconfig files to allow building
> > on non-SN2 configs.  Due to the resulting change in link order, it is now
> > necessary to use late_initcall() for IOC4 subdriver initialization.
> > 
> > ...
> >
> > +#include <asm/sn/addrs.h>
> > +#include <asm/sn/clksupport.h>
> > +#include <asm/sn/shub_mmr.h>
> 
> That doesn't work so good on x86.
> 

-- 
Brent Casavant                          All music is folk music.  I ain't
bcasavan@sgi.com                        never heard a horse sing a song.
Silicon Graphics, Inc.                    -- Louis Armstrong
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/