Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp796869pxf; Thu, 8 Apr 2021 12:45:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwO/ZtBQD00Wi9c8zhNPh+h0ii2tKDR/b2SWSp0D9FsOUlP55hf2cj1XjRXh0HFFSCKYpWw X-Received: by 2002:a17:90a:f3d8:: with SMTP id ha24mr9957797pjb.137.1617911136055; Thu, 08 Apr 2021 12:45:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617911136; cv=none; d=google.com; s=arc-20160816; b=zBij+3VYOtlHM7dbs+xiAoYqk/iG2iBXWMUZpwmeTWoH2qyeGvjcqnQjDAGLpb7S1E K9Hb+zU43NWOmodJkvRm8KeAoqdhvrRsxFoSYQ/Ns1wjXeAnotuu51URp4AlE5kmJo/t wYT7rVz1rJUZI4P/L/JEKT9WZrxKbbnYEZhh2b6W8HocRt74hMMgnEb76uj7jRcknu9d ozicgvZUuG0P0MeBTDDcs0QDCdvKZPhgDj3TzwJTAwzTLPrWla/ZM3Fk1Lgr+NygMO3c scTlaM860ZWYMkZaPM4Cjr3eJOOpngBwnLKCvQ6B4dgz7RZ3XjpGJZMi2UB5f+PorE5Q AExg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=E9M5KeILaLL2DX4wfYwCCBsqzscZxy2gc8zICwtanXk=; b=MlpTOj4gdellOpLxxHJn7ukdpCyqP9lnO+a+JV/SMQ3rY0JtX10yUQyUFwZoBQxvFX oFaXVV13QHfXvLOL3YA79mp14cjFBv3wvvp751wCiwfew6uYEUlbMa83flLWqAD6MFl2 bfUb/FqM4vzTaDJysQ3ot5K8CY4t694kMUF/N3JDUxOYlIjdRe5TLmY7UujraJM32GoR UIgDY4Du4soQL7BNppaWloGNvoT33zWOuFKCRTlUFewscoxJ0/dy2BRZdesJiqUOqTA5 jxFb8U3wYLwM0bMZfmKIB7LgtxvOzllCMq0+SaJKnvMZg7F4vfIPC7MX7wt3BpxauN1D rjOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=cd2isfYs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q5si229773pgp.36.2021.04.08.12.45.21; Thu, 08 Apr 2021 12:45:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=cd2isfYs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232576AbhDHTnb (ORCPT + 99 others); Thu, 8 Apr 2021 15:43:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232528AbhDHTna (ORCPT ); Thu, 8 Apr 2021 15:43:30 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AB90C061761 for ; Thu, 8 Apr 2021 12:43:19 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id t7so1581485plg.9 for ; Thu, 08 Apr 2021 12:43:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=E9M5KeILaLL2DX4wfYwCCBsqzscZxy2gc8zICwtanXk=; b=cd2isfYsbhE4d4Fq/QWNSBdRy9nv0/o/63vwQ8SHwwgOUl7MxMm1f3LDntIrAACkA/ XHhv7UAPcnv1iRX6lOovanhhF9rE+pfYPtP/4m+wl27NZRyLUSETa9+R4NoH0WWYixPQ cY6tjohpXq3USIDbesxcwP0T9rDElGG/DqCNUldLrXuUCiQHq0avzcW5J+U6d5nSQh1D 2OHBJV1MnzePCD594Vt+jvvQ+woM1FsNK7m7EL40r1+4i642IR2M/125+7esXUB/MdKO /cCgzMed0kmWa1/szbWaicYHr1JTQGE/WR1Z3LwzkbgcNgFKPTU0xR4m0nYhvBmOGwvM GICA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=E9M5KeILaLL2DX4wfYwCCBsqzscZxy2gc8zICwtanXk=; b=Yiaj0FO7Q6eU62/eJPCuT4aLCFAAkfk1Nmop8Ux367kA1P80yrtOOWJaEBH84M8fSg TG2e217rOYKUdBI13nD02I3OldjatpS/bz8NzPYfz8uDVFSx2KJy616i2GGrA616Bt7E Am325TN4J1G3FVuP4OasohymLHbUdUTWBa93lTRIMaN3DWcwalbxzB3A7zR10aUgGZ/6 4fv2h0cZ0PpaxpdCadqdxpMHHwUawvBZJMOm7muRQq/nasviNc7Kvb4x2Z5EABSTdq/+ tOJrm+3kiwU1HckSARPpvbVEth5nsiLDzaVwiKFcaTKkTHJXdpuaZZB+PQGJmucc/SDk 3kEQ== X-Gm-Message-State: AOAM533O8UfrVuPgidzjdCKqBAveLBYK+K/ZXphr30BlV4QFbBmQUrRM zLDdowNGMvfsvmVZ41HNG17HP9/F8VfSbQ== X-Received: by 2002:a17:90a:8815:: with SMTP id s21mr9950762pjn.200.1617910998777; Thu, 08 Apr 2021 12:43:18 -0700 (PDT) Received: from [192.168.4.41] (cpe-72-132-29-68.dc.res.rr.com. [72.132.29.68]) by smtp.gmail.com with ESMTPSA id p17sm246558pfn.62.2021.04.08.12.43.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Apr 2021 12:43:18 -0700 (PDT) Subject: Re: [PATCH] io-wq: Fix io_wq_worker_affinity() To: Peter Zijlstra Cc: asml.silence@gmail.com, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Jens Axboe Message-ID: Date: Thu, 8 Apr 2021 13:43:17 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/8/21 3:44 AM, Peter Zijlstra wrote: > > Do not include private headers and do not frob in internals. > > On top of that, while the previous code restores the affinity, it > doesn't ensure the task actually moves there if it was running, > leading to the fun situation that it can be observed running outside > of its allowed mask for potentially significant time. > > Use the proper API instead. Applied, thanks Peter. -- Jens Axboe