Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <YG8NwgD3y/ydzVXI@smile.fi.intel.com>
References: <20210331030520.3816265-1-swboyd@chromium.org> <20210331030520.3816265-5-swboyd@chromium.org> <YG8I2dQWkOIkypqO@gunter> <YG8NwgD3y/ydzVXI@smile.fi.intel.com>
Subject: Re: [PATCH v3 04/12] module: Add printk format to add module build ID to stacktraces
From:   Stephen Boyd <swboyd@chromium.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Evan Green <evgreen@chromium.org>,
        Hsin-Yi Wang <hsinyi@chromium.org>,
        Petr Mladek <pmladek@suse.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        linux-doc@vger.kernel.org, Matthew Wilcox <willy@infradead.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Jessica Yu <jeyu@kernel.org>
Date:   Thu, 08 Apr 2021 12:57:08 -0700
Message-ID: <161791182832.3790633.9176764008911708133@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Precedence: bulk

Quoting Andy Shevchenko (2021-04-08 07:05:54)
> On Thu, Apr 08, 2021 at 03:44:57PM +0200, Jessica Yu wrote:
> > +++ Stephen Boyd [30/03/21 20:05 -0700]:
>=20
> ...
>=20
> > > +static void init_build_id(struct module *mod, const struct load_info=
 *info)
> > > +{
> > > +   const Elf_Shdr *sechdr;
> > > +   unsigned int i;
> > > +
> > > +   for (i =3D 0; i < info->hdr->e_shnum; i++) {
> > > +           sechdr =3D &info->sechdrs[i];
> > > +           if (!sect_empty(sechdr) && sechdr->sh_type =3D=3D SHT_NOT=
E &&
> > > +               !build_id_parse_buf((void *)sechdr->sh_addr, mod->bui=
ld_id,
> > > +                                   sechdr->sh_size))
> > > +                   break;
> > > +   }
> > > +}
> >=20
> > Why not just look for the .note.gnu.build-id section instead of trying
> > to parse each note section? Doesn't it always contain the build id? At
> > least the ld man page seems to suggest this section name should be
> > consistent.

That's basically what this code is doing. We're looking through all the
section headers and finding the ones that are notes and then
build_id_parse_buf() is checking to see if that note is a GNU type note
(name =3D=3D "GNU") and is of the type NT_GNU_BUILD_ID (type =3D=3D 3). We =
don't
need to check for a section name of ".note.gnu.build-id", we can use the
existing code in build_id_parse_buf() that looks for the name and type.

>=20
> Interesting idea (in positive way!), I'm wondering what Clang does in such
> case.
>=20

Clang also inserts a GNU build ID and it works with these patches.