Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 8 Apr 2021 22:37:44 +0200
From:   Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To:     Christoph Hellwig <hch@lst.de>
Cc:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: uaccess: Reduce number of nested macros
Message-ID: <20210408203744.GA18538@alpha.franken.de>
References: <20210408181437.19570-1-tsbogend@alpha.franken.de>
 <20210408194611.GA16189@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210408194611.GA16189@lst.de>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Thu, Apr 08, 2021 at 09:46:11PM +0200, Christoph Hellwig wrote:
> > +#define put_user(x, ptr)						\
> > +({									\
> > +	__typeof__(*(ptr)) __user *__p = (ptr);				\
> > +									\
> > +	might_fault();							\
> > +	access_ok(__p, sizeof(*__p)) ?					\
> > +		__put_user((x), __p) :					\
> > +		-EFAULT;						\
> 
> Why not merge this into a single line, which seems a little more
> readable:
> 
> 	access_ok(__p, sizeof(*__p)) ? __put_user((x), __p) : -EFAULT;	\

I just copied the riscv version ;-) I'll make it one line before applying.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]