Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp833372pxf; Thu, 8 Apr 2021 13:48:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUMmpDoFSOBikmi0hR7Q0msZwDlnDDlRe/pizs4AO4kPe86XW6MP7T0DT8CFE3/Rwd17xm X-Received: by 2002:a17:906:bd2:: with SMTP id y18mr12991573ejg.482.1617914915296; Thu, 08 Apr 2021 13:48:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617914915; cv=none; d=google.com; s=arc-20160816; b=KFmzgk2UG37P6nAulLA9aT8+DY7NqVu66kKrl80g8eUps5LCIAIfjvjTak0aQn5A6Q 7DdJbIi5cXKBkGyep2GlGO/xb1MyspZYf971a/JMmtKZOPop3bjG67Y7lVnEHCE+d1S4 giNQHD7E2ZMk3nHC2Uji6nLypiOP2dpD58kvjjm2LOBFAzL8uJcBUTT1wh1zXox+BA2Z 3PaBh4mBydKNf7CZIwH+vRdJ0q3tsb/c/51AySO2MaLcodvcrkmd1ob9yWLfeE1vKJmz p+QWZBxxxVqxeseJ9g8jlA7K1F+XkCmkj8ziyGmT1vioZ0UsySvPDyC01fNVd2IBrUdP 8NYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=I2uf88F1MX0D+/ieSTh4Dwgs5iH5yDVfXlgdaFvgyLY=; b=eDvWCPfr3v5zabtcYA5C4haTLCLxC+KvHAGaniP0O3eYryDXIAhlopfrYT6IFyOKky C01aiyskHBOvqAJPM61lc6p+/oa0GFiiVWxJhfOfzJKrQSX6yqA+08sqPaNpp6x/s9Bk DiZzJjYsAeMkJcmuFPJQL71voJCQ3QEYkKgDen8jzM1o+yb+sYb/XyT0zPLJV11sdoCp vWQuS2DEjyZNoeo+zUHl4PXV9JrPq0sPVs1IjUl8o4APxfkL8RPVVAuIQipq2E9GX2BU BGJFrYBqMNjWDBJmX5VJWo1WxHs9qKnVZS0dOxxEWaK6ptU/rC+pS/M7738sRfd+odnZ DgUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iLQaYA9i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c11si581310ede.102.2021.04.08.13.48.11; Thu, 08 Apr 2021 13:48:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iLQaYA9i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232327AbhDHUpS (ORCPT + 99 others); Thu, 8 Apr 2021 16:45:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231676AbhDHUpR (ORCPT ); Thu, 8 Apr 2021 16:45:17 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4CFEC061760; Thu, 8 Apr 2021 13:45:04 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id j5so2511204wrn.4; Thu, 08 Apr 2021 13:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=I2uf88F1MX0D+/ieSTh4Dwgs5iH5yDVfXlgdaFvgyLY=; b=iLQaYA9ii9lu78nfawnJ1j3EnThTkKbwXfmYWnlD+/U7jNg54IkiZ2oafwoqsiPQmB bXDztdUBIbPdz5o99zGzRw2KZg9vbtjRnPgftRp7TxyTz68PKMUmaVXcESMvNVgZ3ZmZ HG8DIPq7a0/4u8whVHwTVPV9uWHiPbjXlVwmhL73FaQrNIl/ewoMrsl97+Whcye4jTHt VN0tFRDETneCHToNWF+aw74HYgtgTuVOTcnkgetKzSSygR8nGdp19G2somF84BBIG8/I wgv8MqKba/7QQcLvTD2aPcE9UkePb1cmOJ/E/qdNatzSXo01WtcE2A2O4nUHAXSRNUZW 3odg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=I2uf88F1MX0D+/ieSTh4Dwgs5iH5yDVfXlgdaFvgyLY=; b=XRir7RsbFkk4bAG4SgSvDLV1U0FDvcTVbt9CFsQDqxXiwL//zM+U3aOr4A06VW/YFC inPBIpobjrWVnINlq20YR3ZkuyUIynLUPf/H3mLRgtSBxCbuvzLFgRK+AlEBXRWnD+Je YHEl24xOIW9rFyxzNcHf5yu4JewC+qy36OzN94wyUrbH+j+OzLtmC7UeUfh7LRauoNwZ yP/C6jzKlUN8S4y/6fgAEiSpDIspRaF3LIDG7HVcDYAKWJ3OE0B7r9fPDeRF+4z/X9Fm ZIwWjAhsjV6i8Zh7SgKou+if/l83Xry/9F5/vi2i/MQJlUekmGhYkrXkFd4FMyn7a/RT a86g== X-Gm-Message-State: AOAM531ZFd37M1UbL+huc4K01UQvjXVTbBH48pX64IWAWzTQnUgaNwqQ ntJecKjGAzyrxlu+YaX020c= X-Received: by 2002:a5d:4686:: with SMTP id u6mr14043266wrq.60.1617914703550; Thu, 08 Apr 2021 13:45:03 -0700 (PDT) Received: from LEGION ([39.46.7.73]) by smtp.gmail.com with ESMTPSA id w9sm519597wmg.21.2021.04.08.13.45.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 13:45:03 -0700 (PDT) Date: Fri, 9 Apr 2021 01:44:57 +0500 From: Muhammad Usama Anjum To: Greg Kroah-Hartman , "open list:STAGING SUBSYSTEM" , open list Cc: musamaanjum@gmail.com, kernel-janitors@vger.kernel.org, colin.king@canonical.com, dan.carpenter@oracle.com Subject: [PATCH] staging: rtl8723bs: Remove unnecessary code Message-ID: <20210408204457.GA3079308@LEGION> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The same code is executed when the condition "!show_errors" is true or false. Remove the if condition from here. The original intension of this condition was to not to report any error logs if condition was true. But this driver doesn't has those logs added. So this if condition can be removed. Addresses-Coverity: ("Same code execution") Signed-off-by: Muhammad Usama Anjum --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c index 1b60252545b3..2af66a18200d 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c @@ -1000,8 +1000,6 @@ enum ParseRes rtw_ieee802_11_parse_elems(u8 *start, uint len, break; default: unknown++; - if (!show_errors) - break; break; } -- 2.25.1