Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Subject: Re: [PATCH v1] ata: ahci_tegra: call tegra_powergate_power_off only
 when PM domain is not present
To:     Dmitry Osipenko <digetx@gmail.com>, <axboe@kernel.dk>,
        <thierry.reding@gmail.com>
CC:     <jonathanh@nvidia.com>, <linux-ide@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1617900043-10506-1-git-send-email-skomatineni@nvidia.com>
 <1617900043-10506-2-git-send-email-skomatineni@nvidia.com>
 <32ff84ba-60a7-e498-d656-bcd29d23fb02@gmail.com>
From:   Sowjanya Komatineni <skomatineni@nvidia.com>
Message-ID: <b9f1a8dc-cf46-e501-606e-ce95f32b12d7@nvidia.com>
Date:   Thu, 8 Apr 2021 13:49:37 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <32ff84ba-60a7-e498-d656-bcd29d23fb02@gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2021 20:49:27.0324
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 927407c6-ae15-4c65-3b20-08d8facfcca2
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT012.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB3878
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/8/21 12:58 PM, Dmitry Osipenko wrote:
> 08.04.2021 19:40, Sowjanya Komatineni пишет:
>> This patch adds a check on present of PM domain and calls legacy power
>> domain API tegra_powergate_power_off() only when PM domain is not present.
>>
>> This is a follow-up patch to Tegra186 AHCI support patch series
>> https://lore.kernel.org/patchwork/cover/1408752/
>>
>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>>
>> ---
>>   drivers/ata/ahci_tegra.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c
>> index 56612af..bd484dd 100644
>> --- a/drivers/ata/ahci_tegra.c
>> +++ b/drivers/ata/ahci_tegra.c
>> @@ -287,7 +287,8 @@ static void tegra_ahci_power_off(struct ahci_host_priv *hpriv)
>>   	reset_control_assert(tegra->sata_cold_rst);
>>   
>>   	clk_disable_unprepare(tegra->sata_clk);
>> -	tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
>> +	if (!tegra->pdev->dev.pm_domain)
>> +		tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
>>   
>>   	regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies);
>>   }
>>
> There are two instances of tegra_powergate_power_off() in the driver.
Thanks Dmitry. Sorry missed it. Will fix