Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp928682pxf; Thu, 8 Apr 2021 16:51:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzXEY6yRiVzTNUISEMPXR5XrZIgr2Aj90XvVdIw6ccnjkrCZWgrRuXSwyjFciii5HN9JUm X-Received: by 2002:a17:90b:4c02:: with SMTP id na2mr10840028pjb.77.1617925889447; Thu, 08 Apr 2021 16:51:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617925889; cv=none; d=google.com; s=arc-20160816; b=ZFVQPUBkV1iW0MJWKpl5WT9JuRo2WJc3mZaQNhxwaj7R/AmTmkoVXVXMdxbeARLRyt Ev8vaNDMxwUT8t7eg0Z4teVVz0iDh8KPiUIosZA4NohES/xy2YZGoMhJFvY+TI2Prmrg BXCbqzQVXTrm2LWCJek81K/bIYuF46qPEkMjTEMGGCdEX3yRhSliyTBAQ8hmz9Fo45wb A7y0a2DFO0OnRtAm16NwoADgPfO6xghenK6x9ZITVYH+4qUUSGiFKDDGhgk2rCKXravm auQlaftzbVDBK0CHN/t8Dbr/SOk/RQEqfe9xEg/sCZMoUmkM4tkavQOKG4ORVkIt56h+ kBlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=hJhyO440r+jfw3WvMRf+VhjNMMypQaZgzl1aZpocrd0=; b=WCPOELKHDJBdONKqwOoHzxTTlxAiX0CoShFl05cx/n8QiPbWMilC75Lzi5ef/t4q36 XUbppY1kbcZOwjjeOF70yKXpe/2m530+cTPZkZghCixYVIHl1MXF9x3D4m+sXzMoN7WP K4SoO+p0BLt1yoxAx8kcpBClXDXu8TmlOr1CJURKD0AZpZkJ9YxDtenH0lHMaBooDADI MluKYkp+k3aBq5jY5RAL8pSr0VdgKH2n1ogsgILj2PIfKU5i7IGa7qcyub3iQl2SMQg2 3kPFnQg928TA0AXEQdup+dQwJuj12tAMRcUHEAEMd/rEO0mlBmdciDHrTpvQbF0NWe4m Hj+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=J2HgrMI1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j13si1054612pfa.196.2021.04.08.16.51.16; Thu, 08 Apr 2021 16:51:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=J2HgrMI1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233055AbhDHXus (ORCPT + 99 others); Thu, 8 Apr 2021 19:50:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:34724 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232793AbhDHXuj (ORCPT ); Thu, 8 Apr 2021 19:50:39 -0400 Received: by mail.kernel.org (Postfix) with ESMTPS id AB13C610F8; Thu, 8 Apr 2021 23:50:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617925827; bh=F0uP/nWIdK+V6oyBdJT4pqjUo8NRNN3upI17deigMdg=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=J2HgrMI1lQOIkUsYhQkTp9OpJKHBahC3silK+rCND8XenJo7916nmDnJf+9lff0s4 fbyYFBfRB4Hd6IJ4XvBlTiKQRnC9sI/3eg0wfI4ihgCUoEH1LKthZZHIIuzMJf2Iqc KvMCVJO2iMOE2gfwbmJSFEsAXRqyTQU4pS17PrDMrcIjAsoEv7hhanP06hAsg0XusZ mR/53AJzBJdya6C9Jna84HZ0qU6+KBoupflmwO/VOFbSs04/4+FzVd1PwF9/7DGbA/ hbYo84RNDuWQwcMK404YU4nQM88rd9jMjfaQhRlaFOpsl1dwx0J1BBtWVfNselUKKu FZtzlsSxX5X6A== Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id 9AC7A60975; Thu, 8 Apr 2021 23:50:27 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] net: ipv6: check for validity before dereferencing cfg->fc_nlinfo.nlh From: patchwork-bot+netdevbpf@kernel.org Message-Id: <161792582762.13386.8901145268048636141.git-patchwork-notify@kernel.org> Date: Thu, 08 Apr 2021 23:50:27 +0000 References: <20210408220129.GA3111136@LEGION> In-Reply-To: <20210408220129.GA3111136@LEGION> To: Muhammad Usama Anjum Cc: davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, colin.king@canonical.com, dan.carpenter@oracle.com, stable@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 9 Apr 2021 03:01:29 +0500 you wrote: > nlh is being checked for validtity two times when it is dereferenced in > this function. Check for validity again when updating the flags through > nlh pointer to make the dereferencing safe. > > CC: > Addresses-Coverity: ("NULL pointer dereference") > Signed-off-by: Muhammad Usama Anjum > > [...] Here is the summary with links: - net: ipv6: check for validity before dereferencing cfg->fc_nlinfo.nlh https://git.kernel.org/netdev/net/c/864db232dc70 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html