Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210408125429.199592-1-zhaoxuehui1@huawei.com>
In-Reply-To: <20210408125429.199592-1-zhaoxuehui1@huawei.com>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Thu, 8 Apr 2021 17:20:15 -0700
Message-ID: <CAKwvOd=4ebTNPMOD5K_tUDOY6jx-VT29kUNv=d8ZLxG+1bv6=w@mail.gmail.com>
Subject: Re: [PATCH -next] lib: zstd: Make symbol 'HUF_compressWeights_wksp' static
To:     Zhao Xuehui <zhaoxuehui1@huawei.com>,
        Nick Terrell <terrelln@fb.com>
Cc:     "Gustavo A . R . Silva" <gustavoars@kernel.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Miguel Ojeda <ojeda@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, yangjihong1@huawei.com,
        zhangjinhao2@huawei.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Apr 8, 2021 at 5:55 AM Zhao Xuehui <zhaoxuehui1@huawei.com> wrote:
>
> The symbol 'HUF_compressWeights_wksp' is not used outside of
> huf_compress.c, so this commit marks it static.

Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

Quite a few other functions are declared in a header, but I don't see
any existing callers in tree.  I wonder if the maintainer could
consider cleaning these up so that we don't retain them in binaries
without dead code elimination enabled, or if there's a need to keep
this code in line with an external upstream codebase?

>
> Signed-off-by: Zhao Xuehui <zhaoxuehui1@huawei.com>
> ---
>  lib/zstd/huf_compress.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/zstd/huf_compress.c b/lib/zstd/huf_compress.c
> index fd32838c185f..1e5e001c3d41 100644
> --- a/lib/zstd/huf_compress.c
> +++ b/lib/zstd/huf_compress.c
> @@ -79,7 +79,8 @@ unsigned HUF_optimalTableLog(unsigned maxTableLog, size_t srcSize, unsigned maxS
>   * Note : all elements within weightTable are supposed to be <= HUF_TABLELOG_MAX.
>   */
>  #define MAX_FSE_TABLELOG_FOR_HUFF_HEADER 6
> -size_t HUF_compressWeights_wksp(void *dst, size_t dstSize, const void *weightTable, size_t wtSize, void *workspace, size_t workspaceSize)
> +static size_t HUF_compressWeights_wksp(void *dst, size_t dstSize, const void *weightTable,
> +                                      size_t wtSize, void *workspace, size_t workspaceSize)
>  {
>         BYTE *const ostart = (BYTE *)dst;
>         BYTE *op = ostart;
>


-- 
Thanks,
~Nick Desaulniers