Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] ata: ahci_tegra: call tegra_powergate_power_off only
 when PM domain is not present
To:     Sowjanya Komatineni <skomatineni@nvidia.com>, axboe@kernel.dk,
        thierry.reding@gmail.com
Cc:     jonathanh@nvidia.com, linux-ide@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1617915315-13639-1-git-send-email-skomatineni@nvidia.com>
 <1617915315-13639-2-git-send-email-skomatineni@nvidia.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <f1c7a30b-7a29-2913-1ef5-f25eec8fb4ba@gmail.com>
Date:   Fri, 9 Apr 2021 03:19:20 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <1617915315-13639-2-git-send-email-skomatineni@nvidia.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

08.04.2021 23:55, Sowjanya Komatineni пишет:
> This patch adds check to call legacy power domain API
> tegra_powergate_power_off() only when PM domain is not present.
> 
> This is a follow-up patch to Tegra186 AHCI support patch series.
> ---
>  drivers/ata/ahci_tegra.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c
> index 56612af..4fb94db 100644
> --- a/drivers/ata/ahci_tegra.c
> +++ b/drivers/ata/ahci_tegra.c
> @@ -268,7 +268,8 @@ static int tegra_ahci_power_on(struct ahci_host_priv *hpriv)
>  disable_power:
>  	clk_disable_unprepare(tegra->sata_clk);
>  
> -	tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
> +	if (!tegra->pdev->dev.pm_domain)
> +		tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
>  
>  disable_regulators:
>  	regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies);
> @@ -287,7 +288,8 @@ static void tegra_ahci_power_off(struct ahci_host_priv *hpriv)
>  	reset_control_assert(tegra->sata_cold_rst);
>  
>  	clk_disable_unprepare(tegra->sata_clk);
> -	tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
> +	if (!tegra->pdev->dev.pm_domain)
> +		tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
>  
>  	regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies);
>  }
> 

Looks good, thank you.

Reviewed-by: Dmitry Osipenko <digetx@gmail.com>