Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210402014438.1721086-1-srutherford@google.com> <18c68409-5fcf-2f2c-61f2-e8e52aab277e@amd.com>
In-Reply-To: <18c68409-5fcf-2f2c-61f2-e8e52aab277e@amd.com>
From:   Steve Rutherford <srutherford@google.com>
Date:   Thu, 8 Apr 2021 17:49:05 -0700
Message-ID: <CABayD+fi2Q4nqNGiL8nuO3HfqZbq5PoEgimwWtwjX_o0nANFEQ@mail.gmail.com>
Subject: Re: [PATCH] KVM: SVM: Add support for KVM_SEV_SEND_CANCEL command
To:     Brijesh Singh <brijesh.singh@amd.com>
Cc:     KVM list <kvm@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Nathan Tempelman <natet@google.com>,
        Ashish Kalra <Ashish.Kalra@amd.com>,
        Paolo Bonzini <pbonzini@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Apr 8, 2021 at 3:27 PM Brijesh Singh <brijesh.singh@amd.com> wrote:
>
>
> On 4/1/21 8:44 PM, Steve Rutherford wrote:
> > After completion of SEND_START, but before SEND_FINISH, the source VMM can
> > issue the SEND_CANCEL command to stop a migration. This is necessary so
> > that a cancelled migration can restart with a new target later.
> >
> > Signed-off-by: Steve Rutherford <srutherford@google.com>
> > ---
> >  .../virt/kvm/amd-memory-encryption.rst        |  9 +++++++
> >  arch/x86/kvm/svm/sev.c                        | 24 +++++++++++++++++++
> >  include/linux/psp-sev.h                       | 10 ++++++++
> >  include/uapi/linux/kvm.h                      |  2 ++
> >  4 files changed, 45 insertions(+)
>
>
> Can we add a new case statement in sev_cmd_buffer_len()
> [drivers/crypto/ccp/sev-dev.c] for this command ? I understand that the
> command just contains the handle. I have found dyndbg very helpful. If
> the command is not added in the sev_cmd_buffer_len() then we don't dump
> the command buffer.
>
> With that fixed.
>
> Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>

Nice catch, will follow-up shortly.


Steve