Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp984567pxf; Thu, 8 Apr 2021 18:48:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxh1SuMoHHiZu7niWwZunNeYusQvpHhjTSR0PNGaqetxRsPFc/36d48rqwatotaKAukggDa X-Received: by 2002:aa7:c5d0:: with SMTP id h16mr4344233eds.7.1617932888232; Thu, 08 Apr 2021 18:48:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617932888; cv=none; d=google.com; s=arc-20160816; b=hMXnqQMenlcLJTnQpzd1gG8MJaEd4rNRhPHgwE2dT1i1oC/SQDVRR9Whkf1qLV8XCa YyiZYQN7/++8K0zSbpr97hTjBnzv0bgOwVnSlb8KYSGmddVhSLGU2zaI9pca+lc7l5Pf bP0kM07jBsPrlRsIBmixiu/8I5cHH+4gFM6eWXcZCyS1dVYTenlM9JW4B0Dis1gcFsXV Soo797DP3U9xmb1pL/320CO7BwlGtk6hT4on4+jcOAdhG6JPpksGXypzGL4qyNd4lXSQ nJ7Xp5xiXyJSf2/PWq79Hq8+46EDdXRa2DSqKEu1xL0ojt7n5Fmez1EpTvXWFDBs15S3 wM0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=5dOgHGfe8ekQkkIfPTKHJAQISXBTg0sdfLLkjBSwOPY=; b=xsQPRAGbPbcqU2lA3ROiPjbgc5JLdQn/rWPKnd0S6ym2fU9MD5t7+vepMx+cNMm27U /MDzsEbeX0zD/zRFt8fJvnzWNxvrLUoRdOom1gHVadBoB4YHbC8RI8hpkHDw76tKhazN /oSW24MJ4sG+G5eMET5qFebGsy8FTRS64XuxcGTMOSgD7RCPke2NWGovaY0I/7RG+Uuc Utb6NdsDNBBg3HoV/yUdB/Xk4LwaA/8d/tcVqsqcKK1/pyMca3NKcvakIuri/XOj6rJ0 9SCYCALhCHkgyiHZ/eYWbWBV3x76aQht5Zlxbs7ZQ8dii21TkU18nxcYCcLXSPE0tLcL pb0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y2si1090595edu.245.2021.04.08.18.47.45; Thu, 08 Apr 2021 18:48:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233207AbhDIBor (ORCPT + 99 others); Thu, 8 Apr 2021 21:44:47 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:16102 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232996AbhDIBop (ORCPT ); Thu, 8 Apr 2021 21:44:45 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FGgqH5VcKz19KmH; Fri, 9 Apr 2021 09:42:19 +0800 (CST) Received: from huawei.com (10.175.124.27) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.498.0; Fri, 9 Apr 2021 09:44:28 +0800 From: Jia Yang To: , , , CC: , , Subject: [PATCH -next] mmc: sdhci-msm: Remove unnecessary error log Date: Fri, 9 Apr 2021 09:54:24 +0800 Message-ID: <20210409015424.3277212-1-jiayang5@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.124.27] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org devm_ioremap_resource() has recorded error log, so it's unnecessary to record log again. Reported-by: Hulk Robot Signed-off-by: Jia Yang --- drivers/mmc/host/sdhci-msm.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index d170c919e6e4..e44b7a66b73c 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -1863,7 +1863,6 @@ static int sdhci_msm_ice_init(struct sdhci_msm_host *msm_host, struct mmc_host *mmc = msm_host->mmc; struct device *dev = mmc_dev(mmc); struct resource *res; - int err; if (!(cqhci_readl(cq_host, CQHCI_CAP) & CQHCI_CAP_CS)) return 0; @@ -1881,11 +1880,8 @@ static int sdhci_msm_ice_init(struct sdhci_msm_host *msm_host, } msm_host->ice_mem = devm_ioremap_resource(dev, res); - if (IS_ERR(msm_host->ice_mem)) { - err = PTR_ERR(msm_host->ice_mem); - dev_err(dev, "Failed to map ICE registers; err=%d\n", err); - return err; - } + if (IS_ERR(msm_host->ice_mem)) + return PTR_ERR(msm_host->ice_mem); if (!sdhci_msm_ice_supported(msm_host)) goto disable; -- 2.25.1