Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210407021622.1417-1-hdanton@sina.com> <86499c86-d82c-aa18-5b74-053b0a55fd04@kernel.org>
 <20210407082130.1586-1-hdanton@sina.com>
In-Reply-To: <20210407082130.1586-1-hdanton@sina.com>
From:   Hao Sun <sunhao.th@gmail.com>
Date:   Fri, 9 Apr 2021 10:00:33 +0800
Message-ID: <CACkBjsam5s2JBHo-0Vqen17REm6trJANMjA_WmAhPWAFJivWRQ@mail.gmail.com>
Subject: Re: [PATCH] tty: n_gsm: check error while registering tty devices
To:     Hillf Danton <hdanton@sina.com>
Cc:     Greg KH <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org,
        Dmitry Vyukov <dvyukov@google.com>, jirislaby@kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

> Can you share the info you know about the syzbot report?

Sorry for the late reply, I don't know the REPORT information of
syzbot because I haven't deployed it.
The attached reproduction program was generated by syz-repro.
As you can see from the repro.cprog, the bug occurred in the case of
fault injection.

In repro.cprog, line 108-109:
    inject_fault(81);
    syscall(__NR_ioctl, r[0], 0x5423, 0x20000080ul);


Hillf Danton <hdanton@sina.com> =E4=BA=8E2021=E5=B9=B44=E6=9C=887=E6=97=A5=
=E5=91=A8=E4=B8=89 =E4=B8=8B=E5=8D=884:21=E5=86=99=E9=81=93=EF=BC=9A
>
> On Wed, 7 Apr 2021 07:37:53 Jiri Slaby wrote:
> >
> >Yes, the fix makes sense.
>
> Thanks for taking a look.
>
> >But could you elaborate in the commit log when this happens?
> >I only wonder how real this is. I assume you inject faults to allocation=
s?
>
> After looking at Hao's report [1] again, I think you are right as it was
> reported by syzbot too. Can you share the info you know about the syzbot
> report, Hao, something like the line below with the Reported-by prefix?
>
> (This is just an example     Reported-by: syzbot+b804f902bbb6bcf290cb@syz=
kaller.appspotmail.com)
>
>
> [1] https://lore.kernel.org/lkml/CACkBjsYEhOuQUd2qjobumByFtAXyyoGqXgM8gXY=
ZHqsnV8dgUg@mail.gmail.com/