Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750796AbWJLTCt (ORCPT ); Thu, 12 Oct 2006 15:02:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751162AbWJLTCt (ORCPT ); Thu, 12 Oct 2006 15:02:49 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:63410 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1750796AbWJLTCs (ORCPT ); Thu, 12 Oct 2006 15:02:48 -0400 Date: Thu, 12 Oct 2006 20:02:45 +0100 From: Christoph Hellwig To: Arjan van de Ven Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, akpm@osdl.org, mingo@elte.hu Subject: Re: [patch 0/2] Introduce round_jiffies() to save spurious wakeups Message-ID: <20061012190244.GA31384@infradead.org> Mail-Followup-To: Christoph Hellwig , Arjan van de Ven , linux-kernel@vger.kernel.org, akpm@osdl.org, mingo@elte.hu References: <1160496165.3000.308.camel@laptopd505.fenrus.org> <20061011172331.GA13099@infradead.org> <1160589297.3000.389.camel@laptopd505.fenrus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1160589297.3000.389.camel@laptopd505.fenrus.org> User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 918 Lines: 19 On Wed, Oct 11, 2006 at 07:54:57PM +0200, Arjan van de Ven wrote: > > > An alternative would have been to introduce mod_timer_rounded() or > > > somesuch APIs (but there's many variants that take jiffies); I feel that > > > an explicit caller based rounding actually is quite reasonable. > > > > I think the API you proposed is horrible. Having jiffies exposed in > > ani API is a mistake, and adding more makes this problem worse. > > and other people like Linus disagree with you. The only argument from Linus was about getting rid of jiffies completly. He certainly didn't complain when we added interfaces to reduce jiffies use in the past (e.g. the msleep APIs) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/