Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1018542pxf; Thu, 8 Apr 2021 20:09:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVcYjCJeYcoe1zoUrfDvW/u7oPmF91s8dEbjZIVQHDI67Wa3iMqwlVecMEUsAwWp2Hq1gw X-Received: by 2002:a17:902:ec87:b029:e9:8772:6668 with SMTP id x7-20020a170902ec87b02900e987726668mr7026756plg.15.1617937788672; Thu, 08 Apr 2021 20:09:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617937788; cv=none; d=google.com; s=arc-20160816; b=sDi+2QQGFfkUbevNmKHJlvCL68IXFIWXWjmw56p2n2FxnpCjuEa5Q6EsPLcUI6fLJ6 7GfPm6lxghYAN8VtfEi9j74Q0sdvNsn9gv9zaaUvFOvEU0t4+2ZYEpM/r0mOA6l/PVz2 2ThtbLpGOInaAF4GWk6UuJ7BkT3+xxR51DZ43cgUv4iIEr+qvz/6kYX1OIWpGqi1rWaP vj/ZsMrikRysF9BYAq+6UqkJ9NYUvMm+mAmtF9FIow8m8hbquwtstNPGPL4YtKNfzDWH 5UzxaGMU9N9XsCqUhKhF3a4ZiQZTDQHu6hdqegBTVRGVmWS/kTDCoexoFP4Qer5omzMo C7Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=h3/zuAkLa/ADOI4qQOD5EyWX5f7zNMFVEr3AGRbxlzs=; b=t+nPctx8vEF2NvtTIHfzxb6aVD8LFlr+7ubpbI4nBk/frQKIet9SWuDqoqXWw9XTPm 8eYqoi9iSvzCKXc90f6A0AdYQqym8p9IV2jDrU1Es4g4faZHWa0/VOlZcf/c/+YAU4SU eceprOKBhoA/R9Ioks6Q69WbN5BkNAICCFjJSybXjN96gnOxzP/M+mPiuQJPbnyjmEyl o0F7A3DJs4oubOmtkuH7D25qIwEsEow4LAQeWEMf+XJYH6KFvCNkk/gedGaRHtmVZIHn EE2uWa9pBVx2aQx3s7I7gTjYKj2+uvzM6m/RTV01TCVW3tvKzjXln+jWnNR26D/ErMnB Ln9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Qu68/Utb"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q11si1392071pgr.107.2021.04.08.20.09.36; Thu, 08 Apr 2021 20:09:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Qu68/Utb"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232662AbhDIDJD (ORCPT + 99 others); Thu, 8 Apr 2021 23:09:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232926AbhDIDJD (ORCPT ); Thu, 8 Apr 2021 23:09:03 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BB43C061762 for ; Thu, 8 Apr 2021 20:08:51 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id t22so2850052pgu.0 for ; Thu, 08 Apr 2021 20:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=h3/zuAkLa/ADOI4qQOD5EyWX5f7zNMFVEr3AGRbxlzs=; b=Qu68/UtbNay6Ey8RBiWsqTf7H769Hs16vmlRffRA305itJafW9w8eOhm2Ks/ZI5lRW MO6vcAGxVhQDBFf6O80cqlCf31Ae8d44QgEsiuUOhKnoHv8NjDmFO8f8sZ2dcabZROgI LSWCTwdC7ovN6o7lj2OP2rTjHyPpV+ySSgqD0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=h3/zuAkLa/ADOI4qQOD5EyWX5f7zNMFVEr3AGRbxlzs=; b=lvd/fXoSJg63qDb86gY8c/Le1g9zcjrD6ryrlyJs48vuBt/S0f+cQOP4gAVO8gPvAo F1OrieHWXmlS/MBhRHmTPFU7Uxm7s31RyxLu/0B+bi5d6sX+n40pqnHUhTQ6NGL5BAgA Hsq2HRApBHOhIG7WSQ9uNowu7p9Rb1q6ZXn8BFjipcaMegZUzeku9ZnASCJEO43gyZ2e 2TxqzrfeeNgqZxbJ7UYuKdd8LsfYeHX77qR/I1rV08dXxB+PHMCA7+Avk+OpsI7nZidG 29Ma6syyFSy6hY7ha2QnlQryvsHbJ8wM2hLNY0ckXHsLqPcQ9YKaHGbTh/osEft2y8yS d0bQ== X-Gm-Message-State: AOAM533YE50OyLiy1+ipwhq0ZN+J+epP24sMt56dY+Z0ZImzKylqjzom X+nPMeowPVzL+r4NAsd16UkaWw== X-Received: by 2002:a63:390:: with SMTP id 138mr11306786pgd.8.1617937730705; Thu, 08 Apr 2021 20:08:50 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id i14sm625160pgk.77.2021.04.08.20.08.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 20:08:50 -0700 (PDT) Date: Thu, 8 Apr 2021 20:08:49 -0700 From: Kees Cook To: Greg Kroah-Hartman Cc: Masahiro Yamada , Michal Marek , linux-kbuild@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/20] kbuild: scripts/install.sh: prepare for arch-specific bootloaders Message-ID: <202104082008.25EB080@keescook> References: <20210407053419.449796-1-gregkh@linuxfoundation.org> <20210407053419.449796-6-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210407053419.449796-6-gregkh@linuxfoundation.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 07, 2021 at 07:34:04AM +0200, Greg Kroah-Hartman wrote: > Despite the last release of LILO being in 2015, it seems that it is > still the default x86 bootloader and wants to be called to "install" the > new kernel image when it has been replaced on the disk. To allow > arch-specific programs like this to be called in future changes, move > the logic to an arch-specific test now. > > Signed-off-by: Greg Kroah-Hartman Reviewed-by: Kees Cook -- Kees Cook