Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210409024639.1092204-1-wanjiabing@vivo.com>
In-Reply-To: <20210409024639.1092204-1-wanjiabing@vivo.com>
From:   Steve French <smfrench@gmail.com>
Date:   Thu, 8 Apr 2021 22:53:06 -0500
Message-ID: <CAH2r5muuziT__TfpFWgeQkXRLkE0ZmekAXLBVwxwOAmCAFrh2w@mail.gmail.com>
Subject: Re: [PATCH] fs: cifs: Remove repeated struct declaration
To:     Wan Jiabing <wanjiabing@vivo.com>
Cc:     Steve French <sfrench@samba.org>,
        CIFS <linux-cifs@vger.kernel.org>,
        samba-technical <samba-technical@lists.samba.org>,
        LKML <linux-kernel@vger.kernel.org>, kael_w@yeah.net
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

merged into cifs-2.6.git for-next

On Thu, Apr 8, 2021 at 9:47 PM Wan Jiabing <wanjiabing@vivo.com> wrote:
>
> struct cifs_writedata is declared twice.
> One is declared at 209th line.
> And struct cifs_writedata is defined blew.
> The declaration hear is not needed. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>  fs/cifs/cifsglob.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
> index ec824ab8c5ca..5ec60745034e 100644
> --- a/fs/cifs/cifsglob.h
> +++ b/fs/cifs/cifsglob.h
> @@ -1316,8 +1316,6 @@ struct cifs_readdata {
>         struct page                     **pages;
>  };
>
> -struct cifs_writedata;
> -
>  /* asynchronous write support */
>  struct cifs_writedata {
>         struct kref                     refcount;
> --
> 2.25.1
>


-- 
Thanks,

Steve