Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1617870662-78127-1-git-send-email-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <1617870662-78127-1-git-send-email-jiapeng.chong@linux.alibaba.com>
From:   Steve French <smfrench@gmail.com>
Date:   Thu, 8 Apr 2021 23:09:47 -0500
Message-ID: <CAH2r5mtmeMpkp=vAZYws7c7O+bXo-0XCmLLtNPLUYqV3rByqpA@mail.gmail.com>
Subject: Re: [PATCH] cifs: Remove useless variable
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     Steve French <sfrench@samba.org>,
        CIFS <linux-cifs@vger.kernel.org>,
        samba-technical <samba-technical@lists.samba.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

merged into cifs-2.6.git for-next

On Thu, Apr 8, 2021 at 3:33 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Fix the following gcc warning:
>
> fs/cifs/cifsacl.c:1097:8: warning: variable =E2=80=98nmode=E2=80=99 set b=
ut not used
> [-Wunused-but-set-variable].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  fs/cifs/cifsacl.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/fs/cifs/cifsacl.c b/fs/cifs/cifsacl.c
> index d178cf8..fdb258a 100644
> --- a/fs/cifs/cifsacl.c
> +++ b/fs/cifs/cifsacl.c
> @@ -1094,11 +1094,9 @@ static int set_chmod_dacl(struct cifs_acl *pdacl, =
struct cifs_acl *pndacl,
>         struct cifs_ace *pnntace =3D NULL;
>         char *nacl_base =3D NULL;
>         u32 num_aces =3D 0;
> -       __u64 nmode;
>         bool new_aces_set =3D false;
>
>         /* Assuming that pndacl and pnmode are never NULL */
> -       nmode =3D *pnmode;
>         nacl_base =3D (char *)pndacl;
>         nsize =3D sizeof(struct cifs_acl);
>
> --
> 1.8.3.1
>


--=20
Thanks,

Steve