Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 8 Apr 2021 22:05:08 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Tian Tao <tiantao6@hisilicon.com>
Cc:     <christian.brauner@ubuntu.com>, <masahiroy@kernel.org>,
        <ktkhai@virtuozzo.com>, <linux-kernel@vger.kernel.org>,
        "Zhiqi Song" <songzhiqi1@huawei.com>
Subject: Re: [PATCH] init/version.c: remove unused including
 <linux/version.h>
Message-Id: <20210408220508.c7ce7b1b90202a19223ed1f4@linux-foundation.org>
In-Reply-To: <1617863218-14905-1-git-send-email-tiantao6@hisilicon.com>
References: <1617863218-14905-1-git-send-email-tiantao6@hisilicon.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 8 Apr 2021 14:26:58 +0800 Tian Tao <tiantao6@hisilicon.com> wrote:

> Remove including <linux/version.h> that don't need it.
> 

Um, how can version.c possibly not include version.h?

Sure, it may obtain access to version.h via some other include, but
that's plain luck and nonsense.  And it's unreliable and it requires
whichever-header-is-doing-this to continue to include version.h on
behalf of some .c file which should be including it directly!