Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: mJqPpI43p5gaEnACdtotZ0yYRiXwj9q/TeQIAstLghj7PjMpBZ6DPfHABPQNCTm+x5SxHUolgB
 mQD/IlkiYO5kYVlpw+yzz8a5ld1htnJ78/TaZE9FBosg2xn2CPnbHby8kqyji3CtELGKooetTS
 2miOrwMkbHvDhJ3yihVtpOs1hHxeYYLv7QbWbwtTsyYfPl4138gKISL0vTgew8I7mvJqWYaQCn
 rkk7a8NG+Zl+8pWDyzlISbAJ48YmjBNtrTc7S8ZguczjNr3azeuLS66T0pDPDD30lA7zw/AG0Q
 ngk=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Naresh Kamboju <naresh.kamboju@linaro.org>
CC:     Linux-Next Mailing List <linux-next@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "lkft-triage@lists.linaro.org" <lkft-triage@lists.linaro.org>,
        Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
        linux-block <linux-block@vger.kernel.org>,
        Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
        Hannes Reinecke <hare@suse.de>,
        Damien Le Moal <Damien.LeMoal@wdc.com>
Subject: Re: [next] drivers/cdrom/gdrom.c:586:61: error: 'rq' undeclared
 (first use in this function)
Thread-Topic: [next] drivers/cdrom/gdrom.c:586:61: error: 'rq' undeclared
 (first use in this function)
Thread-Index: AQHXLQAx4caOwbMgo0WKyzWAs7v1OQ==
Date:   Fri, 9 Apr 2021 05:33:24 +0000
Message-ID: <BYAPR04MB49659D343D1F52AEC2FF424386739@BYAPR04MB4965.namprd04.prod.outlook.com>
References: <CA+G9fYtNAEwCk1WkA_25FVUrR0QJ2vt2Dh_w+m-QOSjb8f5TBQ@mail.gmail.com>
 <BYAPR04MB4965A95A5131664085CDD8B786739@BYAPR04MB4965.namprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5bdcccbf-2d45-4a43-212e-08d8fb18ff1d
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2021 05:33:24.8262
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: E+vOCYRoorFpDyOYqV0nuyp5q+j+TuxVTefcPifENJqDXYQdRP6l1wV12SO0jlktUa+ImZWkwDdU3l4lxg3UdLH+vITJZIWmqGYElF4Ltxk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB5591
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Naresh,=0A=
=0A=
On 4/8/21 22:31, Chaitanya Kulkarni wrote:=0A=
> On 4/8/21 22:21, Naresh Kamboju wrote:=0A=
>> Linux next tag 20210408 architecture sh builds failed due to these error=
s.=0A=
>>=0A=
>> # to reproduce this build locally:=0A=
>>=0A=
>> make --silent --keep-going --jobs=3D8=0A=
>> O=3D/home/tuxbuild/.cache/tuxmake/builds/1/tmp ARCH=3Dsh=0A=
>> CROSS_COMPILE=3Dsh4-linux-gnu- 'CC=3Dsccache sh4-linux-gnu-gcc'=0A=
>> 'HOSTCC=3Dsccache gcc'=0A=
>>=0A=
>>=0A=
>> In file included from /builds/linux/include/linux/scatterlist.h:9,=0A=
>>                  from /builds/linux/include/linux/dma-mapping.h:10,=0A=
>>                  from /builds/linux/drivers/cdrom/gdrom.c:16:=0A=
>> /builds/linux/drivers/cdrom/gdrom.c: In function 'gdrom_readdisk_dma':=
=0A=
>> /builds/linux/drivers/cdrom/gdrom.c:586:61: error: 'rq' undeclared=0A=
>> (first use in this function)=0A=
>>   586 |  __raw_writel(page_to_phys(bio_page(req->bio)) + bio_offset(rq->=
bio),=0A=
>>       |                                                             ^~=
=0A=
>>=0A=
>> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>=0A=
>>=0A=
>> Regressions found on sh:=0A=
>>   - build/gcc-9-dreamcast_defconfig=0A=
>>   - build/gcc-10-dreamcast_defconfig=0A=
>>   - build/gcc-8-dreamcast_defconfig=0A=
>>=0A=
>> --=0A=
>> Linaro LKFT=0A=
>> https://lkft.linaro.org=0A=
>>=0A=
=0A=
You can try following fix and see if the error goes away.=0A=
=0A=
> This can be fixed by following :-=0A=
>=0A=
> diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c=0A=
> index e7717d090868..742b4a0932e3 100644=0A=
> --- a/drivers/cdrom/gdrom.c=0A=
> +++ b/drivers/cdrom/gdrom.c=0A=
> @@ -583,7 +583,7 @@ static blk_status_t gdrom_readdisk_dma(struct=0A=
> request *req)=0A=
>         read_command->cmd[1] =3D 0x20;=0A=
>         block =3D blk_rq_pos(req)/GD_TO_BLK + GD_SESSION_OFFSET;=0A=
>         block_cnt =3D blk_rq_sectors(req)/GD_TO_BLK;=0A=
> -       __raw_writel(page_to_phys(bio_page(req->bio)) + bio_offset(rq->bi=
o),=0A=
> +       __raw_writel(page_to_phys(bio_page(req->bio)) +=0A=
> bio_offset(req->bio),=0A=
>                         GDROM_DMA_STARTADDR_REG);=0A=
>         __raw_writel(block_cnt * GDROM_HARD_SECTOR, GDROM_DMA_LENGTH_REG)=
;=0A=
>         __raw_writel(1, GDROM_DMA_DIRECTION_REG);=0A=
>=0A=
=0A=