Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] ARM: spear: Fix build error with
 CONFIG_ARCH_SPEAR3XX
To:     Viresh Kumar <viresh.kumar@linaro.org>
CC:     Viresh Kumar <vireshk@kernel.org>,
        Shiraz Hashim <shiraz.linux.kernel@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
References: <20210409015515.258653-1-chenlifu@huawei.com>
 <20210409040315.vc55eogaxs4zu4xb@vireshk-i7>
From:   chenlifu <chenlifu@huawei.com>
Message-ID: <f4285a1b-9da5-d86b-95ec-cc8513936cde@huawei.com>
Date:   Fri, 9 Apr 2021 14:51:21 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <20210409040315.vc55eogaxs4zu4xb@vireshk-i7>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


?? 2021/4/9 12:03, Viresh Kumar д??:
> On 09-04-21, 09:55, Chen Lifu wrote:
>> commit 77f983a9df42 ("spi: pl022: Use GPIOs looked up by the core")
>> deleted 'struct pl022_ssp_controller' member 'num_chipselect'.
>> We get build error when CONFIG_ARCH_SPEAR3XX is set:
>> arch/arm/mach-spear/spear3xx.c:42:3: error: 'struct pl022_ssp_controller' has no member named 'num_chipselect'
>>     42 |  .num_chipselect = 2,
>>        |   ^~~~~~~~~~~~~~
>> arch/arm/mach-spear/spear3xx.c:42:20: warning: initialization of 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
>>     42 |  .num_chipselect = 2,
>>        |                    ^
>>
>> Fix the issue by deleting the initialization of 'num_chipselect'
>> in spear3xx.c.
>>
>> Fixes: 77f983a9df42 ("spi: pl022: Use GPIOs looked up by the core")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Chen Lifu <chenlifu@huawei.com>
>> ---
>>   arch/arm/mach-spear/spear3xx.c | 10 ----------
>>   1 file changed, 10 deletions(-)
>>
>> diff --git a/arch/arm/mach-spear/spear3xx.c b/arch/arm/mach-spear/spear3xx.c
>> index 8537fcffe5a8..f83321d5e353 100644
>> --- a/arch/arm/mach-spear/spear3xx.c
>> +++ b/arch/arm/mach-spear/spear3xx.c
>> @@ -30,16 +30,6 @@ struct pl022_ssp_controller pl022_plat_data = {
>>   	.dma_filter = pl08x_filter_id,
>>   	.dma_tx_param = "ssp0_tx",
>>   	.dma_rx_param = "ssp0_rx",
>> -	/*
>> -	 * This is number of spi devices that can be connected to spi. There are
>> -	 * two type of chipselects on which slave devices can work. One is chip
>> -	 * select provided by spi masters other is controlled through external
>> -	 * gpio's. We can't use chipselect provided from spi master (because as
>> -	 * soon as FIFO becomes empty, CS is disabled and transfer ends). So
>> -	 * this number now depends on number of gpios available for spi. each
>> -	 * slave on each master requires a separate gpio pin.
>> -	 */
>> -	.num_chipselect = 2,
>>   };
> 
> A patch is already applied by Mark to fix this issue.
> 

Thanks.

---
Chen Lifu