Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1142570pxf; Fri, 9 Apr 2021 00:41:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9tvlGu8MMo0WZqE3JGaf5VCeCShs/092m4z99i4Y5K+CNkAzeQ10aRGe3wnm56Cx1qGP5 X-Received: by 2002:a05:6402:229a:: with SMTP id cw26mr16166108edb.266.1617954086801; Fri, 09 Apr 2021 00:41:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617954086; cv=none; d=google.com; s=arc-20160816; b=rFQimxuHrEWZF1qic8nRtVJfnFYkH8wUxVIo0TcCUMErk7vkSvkY58VgZ/2Od68mry 9YNoCyd/o/AJuBH0D67tjiaEvHbsHaQD9HrODfv6y3kMDp00ZKEnJ1Y1VZ4L0JBDznqD kMWFdqYoykd9nilxxpxGlEsj+MyePB3iN/CJB319rdkJJ6l6hPGhhZOM1aZuJ5Q2IVKG VPdQp3vsYnmyNmlVDYOMS67gMa7kgqvxCJK/NLEx9o6XGmnzH7psnN4C+ltStr5i5Zno JJpBLrX2rOH35z+z7LTjbhYgjojjyZFjXBh/x5bpdFcj9mZCFsjPe9kvLe9NDMpgNraD iNzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=B4QetOyO+uFZyq4PpiAKXG68c6M2ubQg27N5PfhAomQ=; b=mZ+9CxWZC4419+5lyCDxKovUUqfvLztPZFKiAzyTm/3TF14R6l6Fb7u57E+Dm3e303 2Hkc+ghz1y7/jRnaeNRLNPVSr1yWjbkCfPNGyAlvq5qpd3qVmbF8qp9IehFpB5KYxld/ C0VnbSFAkXIDJXExCf+w2G1JXlSTH3R+/0Pc3SvgLHk+aPpPnjvKP1CLONbJt+n6UNGp CzquWv2r0E295r7h5Pzho52MOP70zfTdhhQlA2iGE0lvmm17PRRQojotQj5OChZjTIiY BvpCy0zf1yoUSsYTKhvwnF94MP4iQOtpwWjDlkYFoo9RmDu77GZdbjOQWZ/n5Un1f83h xAaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bewilderbeest.net header.s=thorn header.b=WtrW6uKL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=bewilderbeest.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n22si1659724edc.217.2021.04.09.00.41.03; Fri, 09 Apr 2021 00:41:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@bewilderbeest.net header.s=thorn header.b=WtrW6uKL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=bewilderbeest.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231713AbhDIHiz (ORCPT + 99 others); Fri, 9 Apr 2021 03:38:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229621AbhDIHiy (ORCPT ); Fri, 9 Apr 2021 03:38:54 -0400 Received: from thorn.bewilderbeest.net (thorn.bewilderbeest.net [IPv6:2605:2700:0:5::4713:9cab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC888C061760; Fri, 9 Apr 2021 00:38:41 -0700 (PDT) Received: from hatter.bewilderbeest.net (unknown [IPv6:2600:6c44:7f:ba20::7c6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: zev) by thorn.bewilderbeest.net (Postfix) with ESMTPSA id 8142986; Fri, 9 Apr 2021 00:38:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bewilderbeest.net; s=thorn; t=1617953921; bh=B4QetOyO+uFZyq4PpiAKXG68c6M2ubQg27N5PfhAomQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WtrW6uKLJrOMTd0j58ovYOAM7amEbDjdunQFF1e7IfmoolkUoPLKI3iZLlUEUFwRn BqSxhw4iQWian4v4xB7TGHnv/jZsv/5C0hIGDe+izir8HQ8UQRt4EY8xk37/YKtnSS n2iHoBLauDsjJIUTZMXiwgB6PBYsw4MHHj5nNZXg= Date: Fri, 9 Apr 2021 02:38:38 -0500 From: Zev Weiss To: Andy Shevchenko Cc: Joel Stanley , "openbmc@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Andrew Jeffery , Greg Kroah-Hartman , Jiri Slaby , "linux-serial@vger.kernel.org" Subject: Re: [PATCH v5 2/4] drivers/tty/serial/8250: refactor sirq and lpc address setting code Message-ID: References: <20210408011637.5361-1-zev@bewilderbeest.net> <20210408011637.5361-3-zev@bewilderbeest.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 09, 2021 at 02:24:08AM CDT, Andy Shevchenko wrote: >On Thursday, April 8, 2021, Zev Weiss wrote: > >> This splits dedicated aspeed_vuart_set_{sirq,lpc_address}() functions >> out of the sysfs store functions in preparation for adding DT >> properties that will be poking the same registers. While we're at it, >> these functions now provide some basic bounds-checking on their >> arguments. >> >> > >Please, use prefix “serial: 8250_aspeed_vuart:” instead of what you have in >the subject line. I think I have told this already > > Ah, sorry -- I fixed the cover letter after your first comment (which had definitely been under-tagged); for the patches themselves I was following the example of the last patch in that particular area (8d310c9107a2), though I guess that wasn't the right model to follow. I'll use the requested format in the future.