Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] mmc: sdhci-st: Remove unnecessary error log
To:     Laibin Qiu <qiulaibin@huawei.com>, <adrian.hunter@intel.com>,
        <ulf.hansson@linaro.org>, <yuehaibing@huawei.com>
CC:     <linux-mmc@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <20210409023801.3326572-1-qiulaibin@huawei.com>
From:   Patrice CHOTARD <patrice.chotard@foss.st.com>
Message-ID: <39dd50a7-6e85-49e4-8072-e88fcc471714@foss.st.com>
Date:   Fri, 9 Apr 2021 09:42:03 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210409023801.3326572-1-qiulaibin@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Laibin

On 4/9/21 4:38 AM, Laibin Qiu wrote:
> devm_ioremap_resource() has recorded error log, so it's
> unnecessary to record log again.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Laibin Qiu <qiulaibin@huawei.com>
> ---
>  drivers/mmc/host/sdhci-st.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
> index 78941ac3a1d6..d41582c21aa3 100644
> --- a/drivers/mmc/host/sdhci-st.c
> +++ b/drivers/mmc/host/sdhci-st.c
> @@ -400,10 +400,8 @@ static int sdhci_st_probe(struct platform_device *pdev)
>  	res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
>  					   "top-mmc-delay");
>  	pdata->top_ioaddr = devm_ioremap_resource(&pdev->dev, res);
> -	if (IS_ERR(pdata->top_ioaddr)) {
> -		dev_warn(&pdev->dev, "FlashSS Top Dly registers not available");
> +	if (IS_ERR(pdata->top_ioaddr))
>  		pdata->top_ioaddr = NULL;
> -	}
>  
>  	pltfm_host->clk = clk;
>  	pdata->icnclk = icnclk;
> 

Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>

Thanks
Patrice