Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1150206pxf; Fri, 9 Apr 2021 00:58:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxj8MbXKYsdumjGRFvHOXUHDJM17Waogt/vDWz2LRsEedtA5gXlWleBkezJkE5uGEtMVLS+ X-Received: by 2002:a63:6682:: with SMTP id a124mr3164340pgc.363.1617955114369; Fri, 09 Apr 2021 00:58:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617955114; cv=none; d=google.com; s=arc-20160816; b=x3d16dhyFNO6yr1EwpnPgc9DdLLk1Aom6eS7Nf3C6DhSEp8S/F6GoVg1cLpNsIalJN Wy72IA9IMufkLBD6IhrEgcystGqzzryxMBmG9jH6hjj6jBhTZQwx1prv35Orf1Lwro2L 3hoOUKIxrBdE4Xi2Ob8iWjc2t4CK+hxXpOrpPvljN/vS4s9Qc4XJXbfxOo9hw7V9nqo7 yDH//oE6Jy174oIuAZqnNYXKef/yS7EYOQh+6T9fJnTYweY1bkmXJSC/4vWfTIJPAhZe YQL1qtYXP3ppFwUp4SRjWVuAYNRR7oTwlMC019/nsT8cG3g8hcsykaPGfVwKOnC1aLPL gk2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=PeYtssjWwLAn5UzH5jBsN7Xz3YvXlOcURP3kVTDYguI=; b=QTnnTdifni7tsaNOpRlFjqJYB4hZozsCp2KhgfE9h5K+A9rNvBGJ+5Sit1js558WRz 0hZFXerJX1QkYFzBOfdWopayBN2K8QTAwOSfLWUvL6jf5BvR2s1V119kfLnKYSHAy6t+ wfORwRXKiLkr8RQ2FaHK9IEYtxB8GtZ7cdprq0Hjs5S6RlkcA9pBuCBGfSpRORumlOFC BI8N8c1nXjsFoT/T2E0cwKVGVcX2uNuWGns0Jy0GfPNGdTK5WumVlogGaaG/q0oSECUR DNxVCxR/NDm9ENmr2H7p6FE+BvTqYEdCJHteYPmi77ptIwky+2xAKDOyvxp6p4e0xIbA hCPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c1si2141496pgl.447.2021.04.09.00.58.22; Fri, 09 Apr 2021 00:58:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231496AbhDIH56 (ORCPT + 99 others); Fri, 9 Apr 2021 03:57:58 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:15645 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229751AbhDIH55 (ORCPT ); Fri, 9 Apr 2021 03:57:57 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FGr5D1rZNzpWs2; Fri, 9 Apr 2021 15:54:56 +0800 (CST) Received: from huawei.com (10.67.174.37) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Fri, 9 Apr 2021 15:57:42 +0800 From: Chen Hui To: , , , CC: , , Subject: [PATCH -next] PCI: altera-msi: Remove redundant dev_err call in altera_msi_probe() Date: Fri, 9 Apr 2021 15:57:48 +0800 Message-ID: <20210409075748.226141-1-clare.chenhui@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.174.37] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Chen Hui --- drivers/pci/controller/pcie-altera-msi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pci/controller/pcie-altera-msi.c b/drivers/pci/controller/pcie-altera-msi.c index 42691dd8ebef..98aa1dccc6e6 100644 --- a/drivers/pci/controller/pcie-altera-msi.c +++ b/drivers/pci/controller/pcie-altera-msi.c @@ -236,10 +236,8 @@ static int altera_msi_probe(struct platform_device *pdev) res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "vector_slave"); msi->vector_base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(msi->vector_base)) { - dev_err(&pdev->dev, "failed to map vector_slave memory\n"); + if (IS_ERR(msi->vector_base)) return PTR_ERR(msi->vector_base); - } msi->vector_phy = res->start; -- 2.17.1