Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: epdusYrUqQZ6EFueaVnvCsZJ0n5gEgUThsaCWbtQyNYcDE5S8iKSHp3q9EI2QSeSBQVUa5MsEr
 1oFn49ZAo6yg==
IronPort-SDR: diwBal+VNirmZpYNOpdkQahq8CyDYs0AyeoGUVgufIWbvR1QM+UYNuSxQSQHjAbypd305N5vBv
 SVGRTQsGIq1A==
From:   "Tan, Ley Foon" <ley.foon.tan@intel.com>
To:     Chen Hui <clare.chenhui@huawei.com>,
        "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
        "robh@kernel.org" <robh@kernel.org>,
        "bhelgaas@google.com" <bhelgaas@google.com>
CC:     "rfi@lists.rocketboards.org" <rfi@lists.rocketboards.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH -next] PCI: altera-msi: Remove redundant dev_err call in
 altera_msi_probe()
Thread-Topic: [PATCH -next] PCI: altera-msi: Remove redundant dev_err call in
 altera_msi_probe()
Thread-Index: AQHXLRYPLvJ44PKbm0W1mCS0OXQ8R6qr4e1Q
Date:   Fri, 9 Apr 2021 08:55:40 +0000
Message-ID: <BY5PR11MB38933FD0DB01EE34D07ED151CC739@BY5PR11MB3893.namprd11.prod.outlook.com>
References: <20210409075748.226141-1-clare.chenhui@huawei.com>
In-Reply-To: <20210409075748.226141-1-clare.chenhui@huawei.com>
Accept-Language: en-US
Content-Language: en-US
dlp-reaction: no-action
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ad50dd95-191e-40ba-17f6-08d8fb354056
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2021 08:55:40.2418
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: L9eGeh3EEKYd8kgcQBedvysmM7kxvMPttZihW8ajQK63vtBCQ3bshMpLWtdO+Vm7jctlA2n8t4CRQKdzqFZYZg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4401
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Chen Hui <clare.chenhui@huawei.com>
> Sent: Friday, April 9, 2021 3:58 PM
> To: Tan, Ley Foon <ley.foon.tan@intel.com>; lorenzo.pieralisi@arm.com;
> robh@kernel.org; bhelgaas@google.com
> Cc: rfi@lists.rocketboards.org; linux-pci@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH -next] PCI: altera-msi: Remove redundant dev_err call in
> altera_msi_probe()
>=20
> There is a error message within devm_ioremap_resource already, so remove
> the dev_err call to avoid redundant error message.
>=20
> Signed-off-by: Chen Hui <clare.chenhui@huawei.com>
> ---
>  drivers/pci/controller/pcie-altera-msi.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>=20
> diff --git a/drivers/pci/controller/pcie-altera-msi.c
> b/drivers/pci/controller/pcie-altera-msi.c
> index 42691dd8ebef..98aa1dccc6e6 100644
> --- a/drivers/pci/controller/pcie-altera-msi.c
> +++ b/drivers/pci/controller/pcie-altera-msi.c
> @@ -236,10 +236,8 @@ static int altera_msi_probe(struct platform_device
> *pdev)
>  	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM,
>  					   "vector_slave");
>  	msi->vector_base =3D devm_ioremap_resource(&pdev->dev, res);
> -	if (IS_ERR(msi->vector_base)) {
> -		dev_err(&pdev->dev, "failed to map vector_slave
> memory\n");
> +	if (IS_ERR(msi->vector_base))
>  		return PTR_ERR(msi->vector_base);
> -	}
>=20
>  	msi->vector_phy =3D res->start;
>=20
> --


Reviewed-by: Ley Foon Tan <ley.foon.tan@intel.com>