Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <92af36981fa72db5944d28c6a8d6974ec7aff3f2.camel@perches.com>
Subject: Re: [PATCH][next] mlxsw: spectrum_router: remove redundant
 initialization of variable force
From:   Joe Perches <joe@perches.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>,
        Colin King <colin.king@canonical.com>
Cc:     Jiri Pirko <jiri@nvidia.com>, Ido Schimmel <idosch@nvidia.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Fri, 09 Apr 2021 02:11:29 -0700
In-Reply-To: <20210329060441.GI1717@kadam>
References: <20210327223334.24655-1-colin.king@canonical.com>
         <20210329060441.GI1717@kadam>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 2021-03-29 at 09:04 +0300, Dan Carpenter wrote:
> On Sat, Mar 27, 2021 at 10:33:34PM +0000, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > The variable force is being initialized with a value that is
> > never read and it is being updated later with a new value. The
> > initialization is redundant and can be removed.
> > 
> > Addresses-Coverity: ("Unused value")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > ?drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +-
> > ?1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
> > index 6ccaa194733b..ff240e3c29f7 100644
> > --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
> > +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
> > @@ -5059,7 +5059,7 @@ mlxsw_sp_nexthop_obj_bucket_adj_update(struct mlxsw_sp *mlxsw_sp,
> > ?{
> > ?	u16 bucket_index = info->nh_res_bucket->bucket_index;
> > ?	struct netlink_ext_ack *extack = info->extack;
> > -	bool force = info->nh_res_bucket->force;
> > +	bool force;
> > ?	char ratr_pl_new[MLXSW_REG_RATR_LEN];
> > ?	char ratr_pl[MLXSW_REG_RATR_LEN];
> > ?	u32 adj_index;
> 
> Reverse Christmas tree.

Is still terrible style.