Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1206225pxf; Fri, 9 Apr 2021 02:44:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwHfQRglj7m/Wu9ME9QHTW6bBw6dW0Q8Xx/xAYKfSYkhnvHeDDs5gcBjqb5JqnAD/Jio8p+ X-Received: by 2002:a17:90a:e510:: with SMTP id t16mr6750380pjy.224.1617961472455; Fri, 09 Apr 2021 02:44:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617961472; cv=none; d=google.com; s=arc-20160816; b=wZtFWKNJpMhAQp9WYpTlPaLvMQY4BYjQqtupwc3ZKVW3LLZMeF/+Uz0l8p4sIV3wew mFB7gnwEtE9/miv3rY0hhy0m5vneD7yDaxgQTY0XnDduqqDqdCod67VxbZJGlMM0WvO6 XTu8jqgDIvkR0jxXagE026ec9VCw4jzIdsHsDPTYCqARNUQAgMuUOc8QU4YtRtmb/gNe TwEbqOkPrMrYA7bf90o1mANVzg10u9uwUMLwc58d2SDlBoDGwgxDDr+v8315AUbZUlZI eiG27yn6qPlEcBk9bHKEKVeIr8JbDWuHkxnPSDsl0iAg1t3TrKmh7ATz5pTYkY4xtxLd xisg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=qZuxVuH0SvFVyaqI73gPeR99m8nkyujfJtnjM5A6t2k=; b=M9C165l8iwKG/tVydoJ8EMrNOLfcNChyEonUxQTetIMuUNeyVHRbWKwupNyhxzqKEa KAYe/5dOVQNewEmIYshyS6Ph52A6W5q8PbOwxzqu1Sd1ZZfCOddOnd28m6/xEpiwNhBb aJa2sEi0QJaiT8ZwfCTzYg+QuyrDFQjveoyE+bU76LeaenL01kygs/pNV0dYMKdy4w/X dQRbSLX8dGZ0m5fuivlvx2Ldq+h7QUtQYziyOyORu0vbxPj2K9dW47zG6TeN/ez0VCzs HQQaYyTP0cn5xurbEUngwbNhOqMpkFWBB0Ans6hDoWN8t7gJxL2/ViLJhDeh50zxHLNA 0DXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g23si2438651plj.439.2021.04.09.02.44.19; Fri, 09 Apr 2021 02:44:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233087AbhDIJnn (ORCPT + 99 others); Fri, 9 Apr 2021 05:43:43 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:16508 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232892AbhDIJni (ORCPT ); Fri, 9 Apr 2021 05:43:38 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FGtR81YzpzPpY6; Fri, 9 Apr 2021 17:40:36 +0800 (CST) Received: from huawei.com (10.175.127.227) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.498.0; Fri, 9 Apr 2021 17:43:13 +0800 From: Ye Bin To: , Benson Leung , "Enric Balletbo i Serra" CC: , , "Hulk Robot" Subject: [PATCH -next] platform/chrome: cros_ec_lpc: Use DEFINE_MUTEX() for mutex lock Date: Fri, 9 Apr 2021 17:51:38 +0800 Message-ID: <20210409095138.2293869-1-yebin10@huawei.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Originating-IP: [10.175.127.227] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org mutex lock can be initialized automatically with DEFINE_MUTEX() rather than explicitly calling mutex_init(). Reported-by: Hulk Robot Signed-off-by: Ye Bin --- drivers/platform/chrome/cros_ec_lpc_mec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_lpc_mec.c b/drivers/platform/chrome/cros_ec_lpc_mec.c index 9035b17e8c86..bbc2884f5e2f 100644 --- a/drivers/platform/chrome/cros_ec_lpc_mec.c +++ b/drivers/platform/chrome/cros_ec_lpc_mec.c @@ -14,7 +14,7 @@ * This mutex must be held while accessing the EMI unit. We can't rely on the * EC mutex because memmap data may be accessed without it being held. */ -static struct mutex io_mutex; +static DEFINE_MUTEX(io_mutex); static u16 mec_emi_base, mec_emi_end; /** @@ -142,7 +142,6 @@ EXPORT_SYMBOL(cros_ec_lpc_io_bytes_mec); void cros_ec_lpc_mec_init(unsigned int base, unsigned int end) { - mutex_init(&io_mutex); mec_emi_base = base; mec_emi_end = end; }