Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1206295pxf; Fri, 9 Apr 2021 02:44:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz3Wb4ttyf6qsf6ya4CepMFOKUVPggxJUWNCoLVfJ6NmoE6QnaMLWwL1bX/aGGxFCyBeLty X-Received: by 2002:a17:902:720b:b029:e9:abcc:e60a with SMTP id ba11-20020a170902720bb02900e9abcce60amr2804158plb.20.1617961479262; Fri, 09 Apr 2021 02:44:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617961479; cv=none; d=google.com; s=arc-20160816; b=X0a+xvKfq0Rfptn7ef29B+86O0/QEmdUG8NbKnvlb1PlFKDjPnBF5N0/NyWvvO4GkY RMx+albkjT7vBz1zVcl/hcICcBUaHicUUQyO3baTe+xpIoqATeRH6isB20f3g4OiUOK6 TZYaOpshw1DTxzokqdSpZmQx7QT28XHDtZdyUlLT15MxMUIPLXoTmtlHOvznnav6JpXT PhML5tAu168ZU1zky1hNaRDXjrrmWJwWoYKz3I9/ar+ObD4P3GULr9aqzqsbEbMdjpFL spAi2/i2EjUKWrGaaQhV5Oy3OqAVfzzy80vW6/81QitDKBdBd/pub2E5KC6qmffyYgIF N7xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=7iAKNzE7g41SdqpkdmFQKDuqqVb7RwU5BaIZfiHW70k=; b=zuxu73VmasCqR1F53H3Hw0K9It40OdlLJsDCAHGOZY1W1dy5YavvndP5ca13UMAqIj UsR5QfEIfkFrX28MWKA2LmTAi0za1VbWZSLovPfoc7RgnrrakG/Q/qOuEyT7MfcqemQ2 oa7EegisfmAG7GCaGB6Ju0NeSXXOoBcw8yhvTFFqIEAjSfqGBcraifshys6+ZLA7uP8y J24NTjFFX70zkRqbGidiRWqRyMTUxU/HRyirpaFjtGukzGXN+EYor1r4OFXoXip6+r0z FNbcvwTuku0JbqZQMmn7vyjCYVUPMSklZ+Qjd9CGL8IEd5KYyHjqlWVLyrHj09esL6Lk T3cA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m64si2234265pgm.469.2021.04.09.02.44.27; Fri, 09 Apr 2021 02:44:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232900AbhDIJnv (ORCPT + 99 others); Fri, 9 Apr 2021 05:43:51 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:16120 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232732AbhDIJnl (ORCPT ); Fri, 9 Apr 2021 05:43:41 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FGtRv0jpsz19L9r; Fri, 9 Apr 2021 17:41:15 +0800 (CST) Received: from huawei.com (10.175.127.227) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Fri, 9 Apr 2021 17:43:20 +0800 From: Ye Bin To: , Benjamin Herrenschmidt , Andrew Morton , Mike Rapoport , Al Viro CC: , , , Hulk Robot Subject: [PATCH -next] macintosh/via-pmu: Use DEFINE_SPINLOCK() for spinlock Date: Fri, 9 Apr 2021 17:51:45 +0800 Message-ID: <20210409095145.2294210-1-yebin10@huawei.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Originating-IP: [10.175.127.227] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Ye Bin --- drivers/macintosh/via-pmu.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c index 73e6ae88fafd..bab913e3541a 100644 --- a/drivers/macintosh/via-pmu.c +++ b/drivers/macintosh/via-pmu.c @@ -161,7 +161,7 @@ static unsigned char __iomem *gpio_reg; static int gpio_irq = 0; static int gpio_irq_enabled = -1; static volatile int pmu_suspended; -static spinlock_t pmu_lock; +static DEFINE_SPINLOCK(pmu_lock); static u8 pmu_intr_mask; static int pmu_version; static int drop_interrupts; @@ -306,8 +306,6 @@ int __init find_via_pmu(void) goto fail; } - spin_lock_init(&pmu_lock); - pmu_has_adb = 1; pmu_intr_mask = PMU_INT_PCEJECT | @@ -389,8 +387,6 @@ int __init find_via_pmu(void) pmu_kind = PMU_UNKNOWN; - spin_lock_init(&pmu_lock); - pmu_has_adb = 1; pmu_intr_mask = PMU_INT_PCEJECT |