Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1617693639-49182-1-git-send-email-jiapeng.chong@linux.alibaba.com>
 <20210406083549.GR25703@kw.sim.vm.gnt>
In-Reply-To: <20210406083549.GR25703@kw.sim.vm.gnt>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Fri, 9 Apr 2021 12:04:51 +0200
Message-ID: <CAMpxmJXRqMuNSvojF3KK1g4b1XWkc57qLKK1LhGNbb=WkWppfQ@mail.gmail.com>
Subject: Re: [PATCH] gpio: gpio-it87: remove unused code
To:     Simon Guinot <simon.guinot@sequanux.org>
Cc:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-gpio <linux-gpio@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Apr 6, 2021 at 10:35 AM Simon Guinot <simon.guinot@sequanux.org> wrote:
>
> On Tue, Apr 06, 2021 at 03:20:39PM +0800, Jiapeng Chong wrote:
> > Fix the following clang warning:
> >
> > drivers/gpio/gpio-it87.c:128:20: warning: unused function 'superio_outw'
> > [-Wunused-function].
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>
> Acked-by: Simon Guinot <simon.guinot@sequanux.org>
>
> > ---
> >  drivers/gpio/gpio-it87.c | 8 --------
> >  1 file changed, 8 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-it87.c b/drivers/gpio/gpio-it87.c
> > index 8f1be34..f332341 100644
> > --- a/drivers/gpio/gpio-it87.c
> > +++ b/drivers/gpio/gpio-it87.c
> > @@ -125,14 +125,6 @@ static inline int superio_inw(int reg)
> >       return val;
> >  }
> >
> > -static inline void superio_outw(int val, int reg)
> > -{
> > -     outb(reg++, REG);
> > -     outb(val >> 8, VAL);
> > -     outb(reg, REG);
> > -     outb(val, VAL);
> > -}
> > -
> >  static inline void superio_set_mask(int mask, int reg)
> >  {
> >       u8 curr_val = superio_inb(reg);
> > --
> > 1.8.3.1

Patch applied, thanks!

Bartosz